Skip to content

Improve code readability by adding type hints #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shima004 merged 1 commit into from
Apr 7, 2026
Merged

Improve code readability by adding type hints #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/adf_core_python/core/component/action/extend_action.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,11 @@ def __init__(
module_manager: ModuleManager,
develop_data: DevelopData,
):
self.world_info = world_info
self.agent_info = agent_info
self.scenario_info = scenario_info
self.module_manager = module_manager
self.develop_data = develop_data
self.world_info: WorldInfo = world_info
self.agent_info: AgentInfo = agent_info
self.scenario_info: ScenarioInfo = scenario_info
self.module_manager: ModuleManager = module_manager
self.develop_data: DevelopData = develop_data
self.result: Optional[Action] = None
self.count_precompute: int = 0
self.count_resume: int = 0
Expand Down
10 changes: 5 additions & 5 deletions src/adf_core_python/core/component/centralized/command_executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,11 @@ def __init__(
module_manager: ModuleManager,
develop_data: DevelopData,
) -> None:
self._agent_info = agent_info
self._world_info = world_info
self._scenario_info = scenario_info
self._module_manager = module_manager
self._develop_data = develop_data
self._agent_info: AgentInfo = agent_info
self._world_info: WorldInfo = world_info
self._scenario_info: ScenarioInfo = scenario_info
self._module_manager: ModuleManager = module_manager
self._develop_data: DevelopData = develop_data

self._result: Optional[Action] = None

Expand Down
10 changes: 5 additions & 5 deletions src/adf_core_python/core/component/centralized/command_picker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,11 @@ def __init__(
module_manager: ModuleManager,
develop_data: DevelopData,
) -> None:
self._agent_info = agent_info
self._world_info = world_info
self._scenario_info = scenario_info
self._module_manager = module_manager
self._develop_data = develop_data
self._agent_info: AgentInfo = agent_info
self._world_info: WorldInfo = world_info
self._scenario_info: ScenarioInfo = scenario_info
self._module_manager: ModuleManager = module_manager
self._develop_data: DevelopData = develop_data
self._count_precompute: int = 0
self._count_prepare: int = 0
self._count_resume: int = 0
Expand Down
Loading