596 and 597 id and shiftNumber for icarAnimalSortingCommandResource#602
596 and 597 id and shiftNumber for icarAnimalSortingCommandResource#602cookeac wants to merge 5 commits intoadewg:Developfrom
Conversation
Sync latest Develop head
Add an id field to icarAnimalSortingCommandResource, which will allow systems to better synchronise commands. Resolves adewg#596
Adding the shiftNumber (milking shift number, but making slightly more generic for reuse) that allows sorting to apply to a shift within a validity period. Resolves adewg#597
There was a problem hiding this comment.
Pull request overview
This PR extends icarAnimalSortingCommandResource to better support command lifecycle management and shift-specific sorting behavior.
Changes:
- Add an
idfield intended to uniquely identify sorting commands (issue #596). - Add a
shiftNumberfield intended to scope sorting within a shift inside a validity period (issue #597).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Change shiftNumber to an array shiftNumbers to allow for multiple shifts.
Harry-UA
left a comment
There was a problem hiding this comment.
shiftNumbers array is optional but the minimum size is one according to the documentation. Shouldn't this be zero?
|
C# code generation was tested, and the behavior is expected for the default openapi-generator-cli. |
Add id and shiftNumber to icarAnimalSortingCommandResource: