Skip to content

596 and 597 id and shiftNumber for icarAnimalSortingCommandResource#602

Open
cookeac wants to merge 5 commits intoadewg:Developfrom
cookeac:596_sorting_id
Open

596 and 597 id and shiftNumber for icarAnimalSortingCommandResource#602
cookeac wants to merge 5 commits intoadewg:Developfrom
cookeac:596_sorting_id

Conversation

@cookeac
Copy link
Copy Markdown
Collaborator

@cookeac cookeac commented Apr 10, 2026

Add id and shiftNumber to icarAnimalSortingCommandResource:

cookeac and others added 3 commits January 22, 2026 08:19
Sync latest Develop head
Add an id field to icarAnimalSortingCommandResource, which will allow systems to better synchronise commands. Resolves adewg#596
Adding the shiftNumber (milking shift number, but making slightly more generic for reuse) that allows sorting to apply to a shift within a validity period. Resolves adewg#597
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends icarAnimalSortingCommandResource to better support command lifecycle management and shift-specific sorting behavior.

Changes:

  • Add an id field intended to uniquely identify sorting commands (issue #596).
  • Add a shiftNumber field intended to scope sorting within a shift inside a validity period (issue #597).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

cookeac and others added 2 commits April 10, 2026 14:11
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Change shiftNumber to an array shiftNumbers to allow for multiple shifts.
Copy link
Copy Markdown
Collaborator

@Harry-UA Harry-UA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shiftNumbers array is optional but the minimum size is one according to the documentation. Shouldn't this be zero?

@mtech-ashelepaev
Copy link
Copy Markdown
Contributor

C# code generation was tested, and the behavior is expected for the default openapi-generator-cli.
The new id property is generated as nullable, while the array property remains non-nullable. Adding "nullable": true in the schema does not change this behavior, which is a known limitation. Also, the "minimum": 1 constraint has no effect on the generated C# code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extend icarAnimalSortingCommandResource with milkshifts Unique identifier for icarAnimalSortingCommandResource.

5 participants