Added schemata-API's without locations #600
Conversation
update the erwinspeybroeck branch
There was a problem hiding this comment.
Pull request overview
Adds location-independent schemata endpoints to the URL scheme OpenAPI example to address #594, while keeping the existing location-scoped variants.
Changes:
- Introduces global schemata endpoints:
GET /schemata,GET /schemata/{scheme-type}, andGET /schemata/{scheme-type}/{scheme}. - Re-adds/keeps the existing location-scoped schemata endpoints and renames their
operationIds to be location-specific (e.g.,get-location-schema-types). - Updates the paths section structure to include both global and location-scoped schemata routes.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
cookeac
left a comment
There was a problem hiding this comment.
I have requested a CoPilot review and merged in the corrections that it suggested (mainly description changes). I did wonder whether it was the right thing to do, to change the existing API's operationIds to have the word "location" and reuse the operationIds on the new APIs, or whether we should have given the new API "location-independent" operationIds. I don't have a strong opinion, but wondered about code generation impacts for existing users.
AlexeyHardCode
left a comment
There was a problem hiding this comment.
Looks very good, thanks @erwinspeybroeck.
One comment on the description: should it differ between the variants with and without location? Currently, both are the same. The usage is quite clear, but it could be useful to clarify why both versions exist. What do you think?
Good point, @cookeac. I’d avoid renaming existing items. |
issue #594 #594