Skip to content

Rephrase secret manager phrasing, opening paragraph was awkward. #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adeutscher merged 1 commit into from
Sep 5, 2026
Merged

Rephrase secret manager phrasing, opening paragraph was awkward. #125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions docs/secret-managers.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
# Secret Managers

This general template has support for using a secret manager service. The services within the template interact with the
secret manager through the `ISecretManagerService` or `ISecretManagerCacheService` interfaces.
`ISecretManagerCacheService` maintains an in-memory cache of secrets in order to avoid overwhelming the secret manager
service by accident.
This general template defines a secret manager service interface for securely holding sensitive configuration values
such as credentials or connection strings. The services within the template interact with an underlying secret manager
service through the `ISecretManagerService` or `ISecretManagerCacheService` interfaces. `ISecretManagerCacheService`
maintains an in-memory cache of secrets in order to avoid overwhelming the secret manager service by accident.

At the moment, there are three available implementations of `ISecretManagerService`:

Expand Down Expand Up @@ -38,8 +38,8 @@ While the other secret managers are more straightforward with their plans, Docke
assumptions that should be documented.

In general, I would encourage the use of a secret manager other than Docker Secrets. Compared to other options it lacks
flexibility. However, it may be all that is needed for a small-scale environment and leaves the architecture open to
be pivoted to a different implementation.
flexibility. However, it may be all that is needed for a small-scale environment and leaves the architecture open to be
pivoted to a different implementation.

Other notes:

Expand Down