Skip to content

3.2.x: backport #8428 / #8336 so collection and reporting storyboards stop failing sellers on seeded-only features #8744

Open

Description

@EvgenyAndroid

On main, #8428 and #8336 qualify independent catalog collection and reporting features: an agent that doesn't offer a feature grades not_applicable rather than failing on a product the fixture seeded (this closed #8254). Both PRs first shipped in v3.3.0-beta.1. No 3.2.x release carries them, and hosted grading puts 3.2 agents on 3.2.8.

Local run on 2026-10-30: our sales agent (https://sell.nofluffadvisory.com/mcp) with its 3.2 line switched on, runner @adcp/sdk 17.0.0-beta.6, the v3.2.8 bundle, schemas from dist/schemas/3.2.8.

Storyboard 3.2.8 3.3.0-beta.1
collection_selection discovery fails ("Product declares collection_targeting_allowed … Expected true, got undefined"), then 6 steps skip prerequisite_failed not applicable
owner_sold_channel_carriage discovery fails on the selector's publisher_domain (expects channel-owner.example), then 4 steps skip not applicable
advanced_delivery_reporting the report step fails the time-threshold and format-breakdown checks on the seeded product not applicable

Every 3.2 seller without these optional features still fails these three storyboards on 3.2.8.

Ask: backport the storyboard parts of #8428 and #8336 to 3.2.x for the next 3.2.x patch, as was done for #8555 and #8581. The hosted-server parts of #8336 already run from main. Happy to open the backport PR if that helps.

Activity

  1. sangilish commented on Nov 5, 2026

    @sangilish
    Contributor

    A bounded acceptance matrix for the storyboard backport, preserving the distinction in #8428/#8336 between a coverage gap and an exercised failure:

    Case Input/evidence Expected boundary
    B01 Complete, schema-valid discovery finds no native product qualifying for one of these optional scopes Retain fixture_unsatisfied / not-applicable as untested coverage. Do not award a feature pass or infer that the seller can never support it.
    B02 Native discovery finds a qualifying product and selected price Execute the scope's assertions against that same product/price. A seeded substitute must not manufacture the capability being graded.
    B03 Discovery is malformed, incomplete, fails validation or breaks pagination Preserve a discovery failure; do not turn an unsuccessful search into B01's completed no-match.
    B04 A selected qualifying product fails a graded behavior/assertion Preserve the actual failure even when another optional scope is untested.
    B05 Full versus standalone invocation, including readback companions when applicable Use the corresponding prepared bindings and verified successful-create history; reject retargeted seller/account/product context instead of borrowing a prior pass.
    B06 Released 3.2.8 versus the new 3.2.x patch candidate Retain the exact SDK, schema root, corpus and selected scope for each run. Keep old failures as baseline evidence and qualify the new patch separately.

    One scope guard: #8336 explicitly introduced time_based_delivery_reporting in 3.3. Fixing advanced_delivery_reporting on 3.2 should not silently import that new 3.3 surface or invent specific time thresholds/observations. The three scenarios named here can be the first acceptance slice; the broader collection changes still need their own scope review.

    These are source-derived review criteria, not an independent rerun of the reported seller or a passing backport qualification. I will leave the backport implementation with you; the released 3.2.8 artifacts should remain unchanged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions