Repository navigation
Colour: save source-aligned Lab fields, palettes and distance measurements - #243
Draft
adarshh347 wants to merge 5 commits into
Draft
adarshh347 wants to merge 5 commits into
adarshh347 wants to merge 5 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
The Colour slot now produces source-aligned, portable working-sRGB and CIELAB channels, a deterministic sampled palette with full membership and disclosed counts/locations, and saved CIELAB ΔE76 distance fields from an explicit pixel or supplied sRGB colour. The existing Lab route displays these records with source-linked probes, path/ROI profiles, fixed-scale comparison and display-only controls. Reopen and export/import reuse the saved measurements without a model. Original source bytes/digests remain authoritative; absent/unsupported profiles are stated as assumptions, not calibrated pigment measurements.
This PR changes only Colour-owned family, contract and test paths. It leaves legacy warmth/chroma services and shared Lab plumbing unchanged. No new dependency or learned model is needed.
Validation
sha256:b1cd10cec94d9ede939675a6df2fab1907b8fdc9aacf57ce24ca310257350737after import. Browser probes matched raw saved numbers. Canonical writes and model calls: zero. The photo control is people/fabric, not the requested household desk/object control.Shared integration requests for A/H
show the colour fieldworks. The generic rules planner cannot pass an explicitly selected pixel intocompare colour to the selected sample, so that prompt refuses even after a panel selection; the family panel performs the direct operation and asks for a missing reference. A/H needs a validated selected-pixel resolver seam.Private finding:
Findings/FINDING-perceptual-core-001B-colour-2026-09-23.mdin the author's unversioned vault. Human status: AWAITING_HUMAN.