Restructure assets into assets/ and consolidate docs - #2
Merged
Conversation
- Move CSS, JS, and images under assets/ (css/, js/, images/) - Remove wave.php and wave2.php; keep legacy redirects in .htaccess - Merge NOTICE into LICENSE attributions section - Remove og-image assets and og:image meta tags - Update README, CHANGELOG, and deploy smoke tests for new paths Co-authored-by: Adam Simms <hello@adamsimms.xyz>
There was a problem hiding this comment.
Pull request overview
Reorganizes the site into a more conventional layout by moving static files under assets/, removing legacy root-level entry points and social preview images, and updating documentation/deploy checks to match the new structure.
Changes:
- Move CSS/JS/images into
assets/and updateindex.phpto reference new asset paths. - Consolidate attributions by merging
NOTICEintoLICENSE, and remove legacy PHP redirect endpoints. - Update docs/changelog and extend deploy smoke tests to validate new asset URLs and legacy redirects.
Reviewed changes
Copilot reviewed 10 out of 18 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
wave.php |
Removed legacy PHP redirect entry point. |
wave2.php |
Removed legacy PHP redirect entry point. |
README.md |
Updated URL/docs and documented new project layout. |
og-image.svg |
Removed Open Graph preview asset. |
NOTICE |
Removed standalone attribution notice (moved into LICENSE). |
LICENSE |
Added “Attributions” section consolidating prior NOTICE content. |
lib/layout.php |
Introduced ASSETS_URL constant for asset path construction. |
index.php |
Updated favicon/CSS/JS paths; dropped OG/Twitter image tags and switched Twitter card type. |
CHANGELOG.md |
Updated unreleased notes to reflect asset restructure and removals. |
assets/js/shared.js |
Added shared WebGL/math/helpers and constants under assets/. |
assets/js/simulation.js |
Added simulator implementation under assets/. |
assets/js/waves.js |
Added bootstrap/orbit/render loop script under assets/. |
assets/js/station-poll.js |
Added polling/readout + simulator retuning logic under assets/. |
assets/css/waves.css |
Added styles under assets/. |
assets/images/favicon.svg |
Added favicon under assets/images/. |
.htaccess |
Documented legacy redirects for removed wave.php/wave2.php. |
.github/workflows/deploy.yml |
Extended production smoke tests to validate asset URLs and legacy redirect behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+57
to
+62
| | Layer | Location | Rationale | | ||
| |-------|----------|-----------| | ||
| | PHP endpoints | Site root | DreamHost serves `index.php` and JSON APIs directly | | ||
| | Shared PHP | `lib/` | Reusable server logic, no public URLs | | ||
| | CSS / JS / images | `assets/` | Cacheable static files, clear separation | | ||
| | Tests | `tests/` | Not deployed; excluded from rsync implicitly by size | |
Comment on lines
+132
to
+133
| code="$(curl -fsS -o /dev/null -w '%{http_code}' "${base}/wave.php")" | ||
| test "${code}" = "301" -o "${code}" = "200" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reorganizes the flat site root into a conventional layout and cleans up redundant files.
assets/css/,assets/js/, andassets/images/NOTICEmerged intoLICENSE(Attributions section)wave.php/wave2.phpremoved; legacy URLs still redirect via.htaccessog-image.png/og-image.svgremoved; Open Graph image meta tags dropped for now (Twitter usessummarycard)Layout after merge
Test plan
assets/css/waves.css,assets/js/waves.js,assets/images/favicon.svgreturn 200/wave.phpand/wave2.phpstill redirect