WDIP-56: option to set an end date when setting up a game#168
Open
utiq wants to merge 3 commits into
Open
Conversation
adamlerer
requested changes
Sep 16, 2022
adamlerer
left a comment
adamlerer
left a comment
Owner
There was a problem hiding this comment.
This looks cool! I'm excited to try it out.
| $currentYear = intval($split[1] ?? 1901); | ||
| $endYear = $Game->endYear; | ||
|
|
||
| if ($currentYear == $endYear && $season == "Autumn" && ($Game->phase == "Builds" || $Game->phase == "Retreats")) { |
Owner
There was a problem hiding this comment.
Is season "Autumn" or "Winter" during builds?
Also, it's possible for both retreats and builds to be skipped (no retreats, no builds), which would miss the end date.
Add || $currentYear > $endYear?
| /* | ||
| * The password is not salted, because it's given out to several people anyway and it | ||
| * isn't worth changing the existing behaviour. | ||
| * isn't worth changing the existing behavior. |
Owner
There was a problem hiding this comment.
Haha don't change Kestas' British spelling.
Collaborator
Author
There was a problem hiding this comment.
oh hahaha, that was the auto-corrector plugin that I have in VSCode lol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check the description and comments on Linear