Remove redundant [agent_defaults] from L2/L3/L4/C1 lesson packs#84
Draft
austinborn wants to merge 1 commit into
Draft
Remove redundant [agent_defaults] from L2/L3/L4/C1 lesson packs#84austinborn wants to merge 1 commit into
austinborn wants to merge 1 commit into
Conversation
gc 1.2.1 rejects the [agent_defaults] table in pack.toml, which broke `gc register` for students running the curriculum on the newer gc 1.2.1 / bd 1.0.5 toolchain. The block was redundant: every agent in each lesson pack already declares the same default_sling_formula in its own agent.toml, and the lesson lint (test-harness/lesson-pack-lint.py) validates the per-agent value rather than the pack-level default. Removing it loses no behavior and is version-safe. This generalizes the L2 fix to L3, L4, and C1, and to L2 itself, whose local fix had not yet reached main. Verified: lesson-pack-lint.py (L2/L3/L4/C1) reports no new findings against the unmodified tree; migration-check.sh passes all 10 structural invariants. Generated by the operator's software factory. City: factory-main · Agent: local-core.builder-5 On behalf of: @austinborn Co-Authored-By: operator-factory-bot <factory-bot@operator-domain.invalid>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the redundant
[agent_defaults]table from the four lesson packs (packs/lessons/{L2,L3,L4,C1}/pack.toml). gc 1.2.1 rejects[agent_defaults]inpack.toml, which brokegc registerfor students running the curriculum on the newer gc 1.2.1 / bd 1.0.5 toolchain.The block was safe to remove. Every agent in each lesson already declares the same
default_sling_formulain its ownagent.toml, and the curriculum's own lint (test-harness/lesson-pack-lint.py) reads the per-agent value rather than the pack-level default. This mirrors the L2 fix already applied locally, generalized to L3, L4, and C1, plus L2 itself, whose local fix had not yet reachedmain.Deferred: the rig-import migration needs a scope decision
The same drift report also covers migrating the rig-import pattern (
[defaults.rig.imports.factory]inpack.tomlmoving to a[[rigs]]block incity.toml) and updating the lab READMEs. That work is not in this PR, because it collides with the curriculum's own test harness and cannot be verified in this environment:test-harness/lesson-pack-lint.pycurrently requires the old pattern.SFI112requires[defaults.rig.imports.factory]inmy-factory/pack.toml;SFI501andSFI502require the lesson docs to show that block and thegc --rig <rig> import add/remove factoryflow.test-harness/behavioral-smoke.shruns that linter, so migrating the pattern without also rewriting the linter, the snapshots undertest-harness/walkthrough-snapshots/, and the walkthrough scripts would make the repo's own checks fail.A correct migration is a coordinated change across the linter, the snapshots, the walkthrough scripts, the
my-factorytemplates, and the lab and capstone docs. It belongs in its own reviewed change rather than bolted onto this one.Test plan
python3 test-harness/lesson-pack-lint.py --lesson L2 --lesson L3 --lesson L4 --lesson C1reports no new findings against the unmodified tree. The two pre-existingSFI100/SFI110errors are aboutmy-factory/{city,pack}.tomlbeing absent in a fresh checkout, before a student copies the templates, and are unrelated to this change.bash test-harness/migration-check.shpasses all 10 structural invariants.gc registersucceeds for each lesson pack. A reviewer with that toolchain should verify, since only gc 1.1.1 is available here.