Skip to content

Improve Dockerfile: Remove unnecessary docker binary duplication #4480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arturmartins wants to merge 6 commits into
base: main
Choose a base branch
from
+5 −2
Open

Improve Dockerfile: Remove unnecessary docker binary duplication #4480

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
28257ca
Improve Dockerfile: Remove unnecessary layer
arturmartins Jun 8, 2026
d4bf7c4
Merge branch 'main' into arturmartins-improve-dockerfile
arturmartins Jun 8, 2026
a155994
Merge branch 'main' into arturmartins-improve-dockerfile
arturmartins Jun 8, 2026
68c6a47
Merge branch 'main' into arturmartins-improve-dockerfile
arturmartins Jun 8, 2026
356748b
Merge branch 'main' into arturmartins-improve-dockerfile
arturmartins Jun 8, 2026
715c75e
Merge branch 'main' into arturmartins-improve-dockerfile
arturmartins Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions images/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ RUN export RUNNER_ARCH=${TARGETARCH} \
&& curl -fLo docker.tgz https://download.docker.com/${TARGETOS}/static/stable/${DOCKER_ARCH}/docker-${DOCKER_VERSION}.tgz \
&& tar zxvf docker.tgz \
&& rm -rf docker.tgz \
&& mkdir -p /docker-bin \
&& install -o root -g root -m 755 docker/* /docker-bin/ \
&& rm -rf docker \
Comment on lines +34 to +36

@arturmartins arturmartins Jun 8, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just following the same process as before, but I would rather use chmod/chown. Happy to do that, if reviewers require it.

Comment on lines +34 to +36
&& mkdir -p /usr/local/lib/docker/cli-plugins \
&& curl -fLo /usr/local/lib/docker/cli-plugins/docker-buildx \
"https://github.com/docker/buildx/releases/download/v${BUILDX_VERSION}/buildx-v${BUILDX_VERSION}.linux-${TARGETARCH}" \
Expand Down Expand Up @@ -65,8 +68,8 @@ RUN adduser --disabled-password --gecos "" --uid 1001 runner \
WORKDIR /home/runner

COPY --chown=runner:docker --from=build /actions-runner .
COPY --from=build /usr/local/lib/docker/cli-plugins/docker-buildx /usr/local/lib/docker/cli-plugins/docker-buildx
COPY --from=build /docker-bin/ /usr/bin/
Comment thread
arturmartins marked this conversation as resolved.
Comment thread
arturmartins marked this conversation as resolved.

RUN install -o root -g root -m 755 docker/* /usr/bin/ && rm -rf docker
COPY --from=build /usr/local/lib/docker/cli-plugins/docker-buildx /usr/local/lib/docker/cli-plugins/docker-buildx

USER runner