workflows: Exclude game libraries from 'content' archive#299
Open
res2k wants to merge 2 commits intoactionquake:cifrom
Open
workflows: Exclude game libraries from 'content' archive#299res2k wants to merge 2 commits intoactionquake:cifrom
res2k wants to merge 2 commits intoactionquake:cifrom
Conversation
Contributor
|
The original purpose for the content-only package was to be used as an all-in-one drop-in mod for anyone who wants to bring their own binary (Yamagi, skuller's q2pro, r1q2, etc..), and to be OS-agnostic. I am not sure how many people actually use this package, but the new Flatpak I'm working on will be using it. The content+game archives are being generated, the only difference being the game binary packaged with it. |
…tform packages ...but keep 'content-only' as a package with all data + game libraries
Contributor
Author
|
I see. So here's another attempt: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't include game binaries in the "content only" archive, but pull them individually for each platform.
This also means that e.g. Windows only contains the Windows game DLLs.
FWIW, there might be a good reason why the "content only" archives included the game binaries.
If so, maybe it's worthwhile to produce both a "content only" and "content+game" archive?