Conversation
✅ Deploy Preview for act-rules ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
daniel-montalvo
left a comment
There was a problem hiding this comment.
One concern around handling merges to the act-rules.github.io and just a couple minor tweaks to the wording. I am also requesting for Rémi to decide if he's comfortable with this or he has other thoughts he wants to add in here.
|
|
||
| ### Merge and publication policy | ||
|
|
||
| To give implementors of ACT Rules time to update implementation data, pull requests cannot be merged on Friday, Saturday, or Sunday. Those three days are reserved for implementors to update their implementation data (automated or otherwise). The publication cycle works as follows: |
There was a problem hiding this comment.
What happens if something gets merged on Monday, or on Tuesday, right before the WAI website update goes live? As I said yesterday, I think we should restrict the updates coming from the act-rules.github.io repo to a specific date and time during the week, which could be Thursdays after the meeting when hopefully all has been merged.
There was a problem hiding this comment.
@daniel-montalvo Thanks for the opportunity to review. I've added a couple comments to address before merging.
Please note that I've only focused on step 4 that happens in the w3c/wcag-act-rules repository.
The workflow for publishing updates to the WAI website is documented at https://wai-website-theme.netlify.app/workflow/
It is my understanding that this PR documents this part of the workflow:
Each Working Group and editorial team defines their own workflow for drafting, reviewing, approving, and submitting updates.
|
Can we discuss this briefly during our regular meeting? Is it okay if I add it to the agenda? |
|
We need to put this on the agenda. I don't think limiting merges to a single day is the right solution. If we want a more controlled release flow the way to do it is through release candidates. That's standard practice in lots of places. The other option as that we don't try to do this. This hasn't ever really been an issue. If coming up with a process is a big hassle we should consider if we want this at all. |
I open a pr on the w3c repo
Looking forward to hearing what other implementers think about this. |
|
Discussed at ACT-Rules CG 19 Feb meeting |
Co-authored-by: Daniel Montalvo <49305434+daniel-montalvo@users.noreply.github.com> Co-authored-by: Rémi Bétin <github@remibetin.fr>
Updated
daniel-montalvo
left a comment
There was a problem hiding this comment.
This still doesn't resolve the problem that would be created if someone merges something into act-rules/act-rules.github.io:main while the automation PR is open. That triggers an action that pushes to w3c/wcag-act-rules:main, which automatically adds up to whatever was on the pull request before that merge. But agree with the overall sentiment on the 19 Feb meeting that this is a minor issue and this can be merged.
This comes out of a conversation during office hours today. We don't have a documented process that ensures implementors have sufficient time to update before we publish new rules / test cases. This should address that.
Need for Call for Review: 2 weeks
How to Review And Approve