Skip to content

Add new option 'additional_dependencies' - #131

Closed
lmignon wants to merge 1 commit into
masterfrom
master-additional-dependecies
Closed

lmignon wants to merge 1 commit into
masterfrom
master-additional-dependecies

Conversation

@lmignon

@lmignon lmignon commented Mar 27, 2026

Copy link
Copy Markdown
Member

used to specify additional dependencies that are not declared in the addons manifests.

used to specify additional dependencies that are not declared in the addons manifests.
@sbidoul

sbidoul commented Mar 27, 2026

Copy link
Copy Markdown
Member

Hm, I think this is not necessary here, because you can add an install_requires key in setup() with the additional dependencies and it will be extended with the dependencies computed from __manifest__.

@sbidoul

sbidoul commented Mar 27, 2026

Copy link
Copy Markdown
Member

Here:

elif isinstance(v, list):
# list set in setup.py, extend with what we get from __openerp__.py
# (for install_requires, classifiers, etc)
assert isinstance(val, list)
for item in val:
if item not in v:
v.append(item)

@lmignon lmignon closed this Mar 27, 2026
@sbidoul
sbidoul deleted the master-additional-dependecies branch March 27, 2026 08:48
@lmignon

lmignon commented Mar 27, 2026

Copy link
Copy Markdown
Member Author

Hm, I think this is not necessary here, because you can add an install_requires key in setup() with the additional dependencies and it will be extended with the dependencies computed from __manifest__.

:-( At least it made me read that code a little more carefully once, but it seems I didn't understood it closely enough (even though its usefulness is declining. . .)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants