Skip to content

feat(cli): add offline config check - #461

Open
EzraCerpac wants to merge 1 commit into
acsandmann:mainfrom
EzraCerpac:wip/rift-config-check
Open

feat(cli): add offline config check#461
EzraCerpac wants to merge 1 commit into
acsandmann:mainfrom
EzraCerpac:wip/rift-config-check

Conversation

@EzraCerpac

Copy link
Copy Markdown

Summary

  • add rift config check --config PATH
  • parse the full config and run semantic validation without starting Rift
  • resolve hotkeys through a static offline map so the command never touches AppKit, Accessibility, WindowServer, Carbon keyboard-layout services, startup commands, or Rift services
  • reject layout-specific character keys that cannot be proven valid offline with a clear error

Tests

  • cargo test --locked common::config_check
  • cargo test --locked sys::hotkey::tests
  • cargo build --locked --bin rift
  • target/debug/rift config check --config rift.default.toml

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 29, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-29T19:46:35.186428Z aecaadb New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@EzraCerpac
EzraCerpac force-pushed the wip/rift-config-check branch from 4bad52c to aecaadb Compare August 29, 2026 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant