fix(protocol): make WorkspaceId Display collision-free - #444
Open
YuriNachos wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WorkspaceId's Display applied
{:08}padding to the concatenated DECIMAL string of idx+version, so{idx:1,version:23}and{idx:12,version:3}both rendered "00000123" — losing positional info (idx is the low 32 bits, version the high 32 bits of the slotmap key per protocol_workspace_id). The collision flows to RIFT_WORKSPACE_ID and the Debug command's id_num.Fix
Reconstruct the original 64-bit key:
((version as u64) << 32) | idx. Preserves the 8-char-zero-padded look, makes the string a stable unique key, transitively fixes id_num with zero other changes.Test plan
cargo test -p rift-protocol— 7 passed, 0 failed, including a new collision-free test (assert_neof the two colliding ids) and a round-trip assertion.