Open
Conversation
NikolasHaimerl
commented
Dec 19, 2025
| signature, | ||
| ); | ||
|
|
||
| if (this.config.cctpFinalizerMode === CctpFinalizerMode.Full) { |
Contributor
Author
There was a problem hiding this comment.
The mode is attestation-only here
amateima
reviewed
Dec 19, 2025
Comment on lines
239
to
241
| const enableCctpFinalizer = env.ENABLE_CCTP_FINALIZER | ||
| ? env.ENABLE_CCTP_FINALIZER === "true" | ||
| : false; |
Contributor
There was a problem hiding this comment.
Are we good to remove this?
Comment on lines
+256
to
+261
| } else if (env.ENABLE_CCTP_FINALIZER) { | ||
| cctpFinalizerMode = | ||
| env.ENABLE_CCTP_FINALIZER === "true" | ||
| ? CctpFinalizerMode.Full | ||
| : CctpFinalizerMode.Off; | ||
| } |
Contributor
There was a problem hiding this comment.
Should we remove the support for ENABLE_CCTP_FINALIZER env entirely?
Contributor
Author
There was a problem hiding this comment.
We are not removing the support for ENABLE_CCTP_FINALIZER, the variable still exists. If ENABLE_CCTP_FINALIZER is false then the mode is going to be off if it is true and the mode is not set then the mode is set to full
NikolasHaimerl
requested review from
ashwinrava,
dohaki,
melisaguevara,
mrice32 and
nicholaspai
as code owners
amateima
approved these changes
Jan 6, 2026
Contributor
|
I think we can close this one. Ashwin added a similar capability during his work for Hyperliquid deposits with the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously if we started the indexer locally the finalizer that publishes the burn events would error.
In this PR we add a finalizer publishing mode to distinguish between activating, deactivation or activating the finalizer with only attestations.