Open
Conversation
Signed-off-by: Gerhard Steenkamp <gerhard@umaproject.org>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Signed-off-by: Gerhard Steenkamp <gerhard@umaproject.org>
Signed-off-by: Gerhard Steenkamp <gerhard@umaproject.org>
Signed-off-by: Gerhard Steenkamp <gerhard@umaproject.org>
0xjorgen
previously approved these changes
Feb 5, 2026
Contributor
0xjorgen
left a comment
There was a problem hiding this comment.
LGTM! Clean implementation for handling failed destination swaps. The actionsSucceeded === false check is correct per indexer logic.
nit: Line 303 in DepositTimesCard.tsx - the non-null assertion (finalOutputAmountUsd!) could be avoided by adding it to the conditional check above.
| textColor="light-100" | ||
| /> | ||
| <Text color="grey-400"> | ||
| (${formatUSD(finalOutputAmountUsd!)}) |
Contributor
There was a problem hiding this comment.
will this crash if finalOutputAmountUsd is undefined?
Contributor
Author
There was a problem hiding this comment.
it might, good catch!
0xjorgen
requested changes
Feb 5, 2026
Contributor
Contributor
Author
Contributor
Author
Signed-off-by: Gerhard Steenkamp <gerhard@umaproject.org>
Signed-off-by: Gerhard Steenkamp <gerhard@umaproject.org>
Contributor
|
Yeah, it feels like this should be handled on the api side. not client-side logic |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




closes FE-95
Morivation
In cases where the destination swap failed, we need to inform the user that they received the bridge token and it's amount.
This solution is a bit hacky since we rely on both the deposit/status endpoint for the initial status of the fill, then we use the /deposit endpoint for more detail, ie the amount received in the bridge token.
In future PR's we should consider removing reliance on the status endpoint altogether and simply use the more data-rich /deposit endpoint.
Examples
Failed swap (USDT => ACX)
Link
Success (USDC => USDT)
Link