Open
Conversation
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
grasphoper
reviewed
Feb 7, 2026
Contributor
grasphoper
left a comment
There was a problem hiding this comment.
A few Qs:
- Is
"editor.defaultFormatter": "esbenp.prettier-vscode",referring to the prettier -- the node module, or prettier -- the vs code extension? If the extension, are there any extra settings to change on the extension for it to usenode_modules/prettierand .prettierrc, .prettierignore and something likeprettier-plugin-solidity? E.g. can it happen that the extension is overriding the prettierrc config? yarn pretty-quick --staged: what prettier path + version is that using?- should we perhaps upgrade versions of
prettier-plugin-solidity,pretty-quickas a part of this change?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add prettier format check for Solidity files (contracts/ and script/) to CI, and add yarn format-contracts convenience command. Also fixes the broken glob in lint-fix.
VSCode / Cursor setup - add this to your workspace or user settings.json:
This ensures VS Code uses the project's node_modules/prettier and .prettierrc to format Solidity files on save, matching what CI enforces. If you don't want format-on-save, you can omit that line and just run
yarn format-contractsbefore committing.Closes ACP-47