Repository navigation
Validate NGFF readback with TensorStore on CPU and GPU - #296
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verify CPU and GPU Zarr output with TensorStore alongside zarr-python. Both single-array and NGFF readback suites use the same 10 codec configurations across three buffered-writer modes. Require c-blosc in every build, remove the unavailable-codec stub and conditional skips, and expose the dependency through the installed CMake and pkg-config metadata.
A shared three-level NGFF fixture checks every advertised level against an analytic reference, validates axes and physical scales, and covers complete and partial shards. Missing shards, corrupt payloads/indexes, and incorrect scales must fail; renamed levels must remain discoverable through NGFF metadata. CI installs the reader dependencies before CTest. The fixture and validation helpers can be reused for #34.
Validation:
CHUCKY_BUILD_SHARED=ON, and rejected a disabled Blosc dependency.Closes #35.