Repository navigation
Prepare stream buffers before capture - #291
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
Retain startup page preparation alongside GPU host placement and shard preparation. Resolve the README additions and platform source list together.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting capture immediately after stream creation can put initial page faults and worker startup into the first append. Prepare buffered input, CPU payload/output buffers, and shard tail/footer buffers during creation, and wait for worker startup before returning. This pays the memory and initialization cost before capture; the README explains explicit camera buffering, bounded drains, and sizing for a pause allowance.
Validation: all 50 non-S3 CPU checks passed. The memory-residency regression fails when the input-page preparation is removed and passes after restoration.