Reverted incorrect (and very slow) process pool code in analyzeOffets function in offsets.py#8
Open
terrycojones wants to merge 1 commit intomasterfrom
Open
Reverted incorrect (and very slow) process pool code in analyzeOffets function in offsets.py#8terrycojones wants to merge 1 commit intomasterfrom
terrycojones wants to merge 1 commit intomasterfrom
Conversation
… function in offsets.py (and fixed the function name typo). Added a few f-strings.
imLew
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And fixed the function name typo. Added a few f-strings.
The process pool
mapcall needed anitertools.repeataround thealignedReadsarg. The arg lists to the map function were also of different lengths (can be checked withstrict=Trueas of Python 3.14 See https://docs.python.org/3/library/functions.html#map). When I fixed the code it was extremely slow because it forks over 3000 processes and has to serialize and pass thealignedReadsobject (which has 30,000 reads in it) for each created process. It's much, much faster just to use the original code. So I reverted to the code as it was before the process pool approach.