Skip to content

chore: use module system and update releases#13

Merged
acmepjz merged 2 commits intoacmepjz:mainfrom
david-christiansen:modules
Nov 17, 2025
Merged

chore: use module system and update releases#13
acmepjz merged 2 commits intoacmepjz:mainfrom
david-christiansen:modules

Conversation

@david-christiansen
Copy link
Copy Markdown
Contributor

Let's see what effect this has on version support in CI.

This PR adds support for the module system. This allows downstream
projects that use modules to depend on MD4Lean. As a consequence, it
removes support for Lean v4.22 and earlier, including the compile-time
conditional support for the old ABI.
@david-christiansen david-christiansen marked this pull request as ready for review November 17, 2025 12:25
@david-christiansen
Copy link
Copy Markdown
Contributor Author

If you'd rather not drop support for those versions, then I can maintain this as a branch until you are. But given that this project is very stable, I suspect that users of older Lean versions can keep depending on the older MD4Lean without issue.

@david-christiansen
Copy link
Copy Markdown
Contributor Author

The use of the module system is important for me because I'm working on making the Lean reference manual support modules, which I expect to greatly improve the time needed for incremental rebuilds when changing the text.

@acmepjz
Copy link
Copy Markdown
Owner

acmepjz commented Nov 17, 2025

I'm OK with these changes. The main usage I concerned is https://github.com/leanprover/doc-gen4, could you add a PR to it to adapt these changes?

If you'd rather not drop support for those versions ... I suspect that users of older Lean versions can keep depending on the older MD4Lean without issue.

May be you can also add a note to README to specify a git hash for users for older Lean versions?

@david-christiansen
Copy link
Copy Markdown
Contributor Author

I added the note.

I don't expect any adaptation to be necessary for clients of the library, but I'll go check.

@acmepjz
Copy link
Copy Markdown
Owner

acmepjz commented Nov 17, 2025

Thank you!

@acmepjz acmepjz merged commit 38ac594 into acmepjz:main Nov 17, 2025
4 checks passed
@david-christiansen
Copy link
Copy Markdown
Contributor Author

Just confirming: doc-gen builds just fine and generates documentation with the code in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants