fix(desktop): exclude top-level _ dirs from sidecar staging - #40
Merged
Conversation
plugins/_archive (retired plugins) rode the wholesale plugins/ copy into the packaged app, and CI's unpacked-resource verifier treated it as a bundled plugin and failed the v0.0.24 release on its missing package.json. Staging now skips _-prefixed dirs at the resource root (worlds/_archive stops shipping as dead weight too), and the verifier tolerates one slipping through an older build. Third member of the _archive family after the release-preflight and workspace-glob cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.0.24 tag build failed at 'Verify unpacked release resources': the wholesale
plugins/copy stagedplugins/_archiveinto the app and the verifier failed it as a bundled plugin with nopackage.json.build.mjsstaging filter now skips_-prefixed dirs at the resource root (also stops shippingworlds/_archiveas dead weight)verify-release.mjstolerates an archived dir slipping through an older buildThird member of the
_archivefamily (after the release-preflight scan and the workspace glob). Localpnpm build:electron+node apps/desktop/scripts/verify-release.mjs macre-run to confirm before merge; v0.0.24 will be re-tagged on the merge commit.