Issue 11 be compatible with rails view annotation comments#12
Open
Issue 11 be compatible with rails view annotation comments#12
Conversation
If:
config.action_view.annotate_rendered_view_with_filenames = true
is set in Rails then each rendered view and partial will have a comment
at the top like:
<!-- BEGIN app/views/thing/index.html.erb -->
When this comment is present before the doctype, it causes the HTML to be
invalid in a way that is not useful so we remove the comment.
G-Rath
requested changes
Oct 13, 2023
Contributor
G-Rath
left a comment
G-Rath
left a comment
There was a problem hiding this comment.
I think we should update the version in a dedicated PR when we are doing the release straight after, in case something comes up between this PR and then (or we discover something else we want to do)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If:
is set in Rails then each rendered view and partial will have a comment
at the top like:
When this comment is present before the doctype, it causes the HTML to be
invalid in a way that is not useful so we remove it.
Resolves #11