chore: reset repo confidence blockers#246
Conversation
Greptile SummaryThis chore PR resets several confidence blockers: it hardens the Helm chart with fail-fast secret validation, fixes Docker Compose build contexts, removes mock/hardcoded service data from Confidence Score: 5/5Safe to merge — only a P2 test-isolation finding, no runtime or data-correctness issues. All changes are well-scoped: Helm validation guards are exercised by the PR's own smoke tests, Docker Compose build-context fixes address the previously flagged nginx/API-base issue, and the frontend mock-removal is backed by new unit tests. The sole finding is a missing afterEach teardown in a test helper. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[ServicesView mounts] --> B{tracingDatasources\nwatch fires}
B -- empty sources --> C[Clear services,\nstop loading]
B -- sources present --> D[Abort previous run\nIncrement discoveryRun\nSet loadingServices=true]
D --> E[Promise.allSettled\nfetchDataSourceTraceServices\nper source]
E --> F{signal.aborted or\nstale runId?}
F -- yes --> G[Discard result silently]
F -- no --> H{All fulfilled?}
H -- yes --> I[Set services,\nclear error\nloadingServices=false]
H -- partial failures --> J[Set services from\nsucceeded sources\nSet partial warning\nloadingServices=false]
H -- all failed --> K[Clear services\nSet full error\nloadingServices=false]
Reviews (2): Last reviewed commit: "chore: reset repo confidence blockers" | Re-trigger Greptile |
e07cb19 to
1a7c218
Compare
|
Follow-up after reviewing PR comments/checks:
Local validation for the follow-up:
Security checks from the first CI run were green: Dependency Review, CodeQL Go, CodeQL JS/TS, Go Vulnerability Check, and Gitleaks. Checks are re-running for the amended commit. |
Summary
progress.txtintentionally trackedValidation
make backend-lintcd backend && go test ./...cd frontend && bun run type-check && bun run test && bun run buildhelm lint charts/acehelm template ace charts/ace -f charts/ace/values-prod.yaml --set postgresql.auth.password=example-password --set backend.jwt.secret=example-secret --set ingress.hosts[0].host=ace.example.test --set ingress.tls[0].hosts[0]=ace.example.testexternalDatabase.password or backend.existingSecret...messagedocker compose -f deploy/docker/demo/docker-compose.yml build ace-backend ace-frontendmake security-local