test(cicero-core): 100% coverage for ApArchiveLoader#830
Open
rockaxorb13 wants to merge 1 commit intoaccordproject:mainfrom
Open
test(cicero-core): 100% coverage for ApArchiveLoader#830rockaxorb13 wants to merge 1 commit intoaccordproject:mainfrom
rockaxorb13 wants to merge 1 commit intoaccordproject:mainfrom
Conversation
Signed-off-by: Aadityavardhan Singh <singhrashmi018@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the low test coverage for
ApArchiveLoaderincicero-core.Previously,
aparchiveloader.jshad ~16% coverage. The critical logic—specifically the validation ofap://protocol requirements and the rewriting of URLs before delegation—was untested, and there was no script to test it.Changes:
Added
packages/cicero-core/test/loaders/aparchiveloader.js:Sinonto mock the parentHTTPArchiveLoader.Updated
packages/cicero-core/package.json:--recursiveflag for the Mocha test runner to ensure tests in subdirectories (like the new loader tests) are correctly discovered and executed.Results
Coverage for
aparchiveloader.jsis now 100%.Before:
After