fix(csharp): escape reserved keywords in enum value declarations#201
Open
yashhzd wants to merge 1 commit intoaccordproject:mainfrom
Open
fix(csharp): escape reserved keywords in enum value declarations#201yashhzd wants to merge 1 commit intoaccordproject:mainfrom
yashhzd wants to merge 1 commit intoaccordproject:mainfrom
Conversation
Enum values using C# reserved keywords (e.g. event, fixed, virtual) caused compilation errors in generated code. Apply toCSharpIdentifier to enum value names and add EnumMember attribute to preserve the original name for serialization when escaping occurs. Closes accordproject#31 Signed-off-by: Yash Goel <yashhzd@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #31
Enum values using C# reserved keywords (e.g.
event,fixed,virtual) produce invalid C# code that fails to compile. This PR applies the existingtoCSharpIdentifiermethod to enum value names, which prefixes reserved keywords with_— consistent with how field names are already handled.When an enum value name is escaped, a
[System.Runtime.Serialization.EnumMember(Value = "originalName")]attribute is added to preserve the original name during JSON serialization, matching the existing pattern used for the@AcceptedValuedecorator.Changes
lib/codegen/fromcto/csharp/csharpvisitor.js: ModifiedvisitEnumValueDeclarationto pass enum value names throughtoCSharpIdentifierand addEnumMemberattribute when the name is escaped.test/codegen/fromcto/csharp/csharpvisitor.js: Added integration test with reserved keyword enum values (event,fixed,virtual) and unit tests for both reserved and non-reserved enum value names.Example
Before (invalid C#):
After (valid C#):
Testing
All 569 tests pass (3 new tests added). No existing tests broken.