fix(typescript): propagate optional modifier for scalar fields#195
Open
Shubh-Raj wants to merge 2 commits intoaccordproject:mainfrom
Open
fix(typescript): propagate optional modifier for scalar fields#195Shubh-Raj wants to merge 2 commits intoaccordproject:mainfrom
Shubh-Raj wants to merge 2 commits intoaccordproject:mainfrom
Conversation
When generating TypeScript code, optional scalar fields were losing their optional modifier. This fix propagates the optional property from the parent field via the forceOptional parameter, avoiding mutation of the shared scalar descriptor. Signed-off-by: Shubh-Raj <shubhraj625@gmail.com>
…-typescript # Conflicts: # package-lock.json
Author
|
@ekarademir @mttrbrts @dselman resolved the merge conflicts. Requesting a review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #194
This PR fixes the bug where optional scalar fields lose their optional modifier (
?) when generating TypeScript code.Changes
forceOptionalvia parameters when handling scalar fields, avoiding mutation of the shared scalar descriptorparameters.forceOptionalwhen determining if a field should have the?modifierFlags
Screenshots or Video
Before fix:
nickname: string;(missing?for optional scalar)After fix:
nickname?: string;(correctly includes?)Related Issues
accordproject/concertoatpackages/concertino/scripts/generateTypes.js:119Author Checklist
--signoffoption of git commit.mainfromfork:fix/scalar-optional-typescript