[refactor / bugfix] language - sort JSON keys, find missing keys#709
Open
MichaelWheeley wants to merge 2 commits intoaccius:mainfrom
Open
[refactor / bugfix] language - sort JSON keys, find missing keys#709MichaelWheeley wants to merge 2 commits intoaccius:mainfrom
MichaelWheeley wants to merge 2 commits intoaccius:mainfrom
Conversation
…e found based on 'en' language
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I have been working to add TH language (pending) however it is a moving target. Between languages there appeared to be an inconsistent sort of indexing of JSON keys making identification of new or missing keys difficult. For each language I have sorted alphabetically, and where missing keys occur added them using the 'en' language version as master.
Type of change
How to test
Checklist
server.js: caches have TTLs and size caps (we serve 2,000+ concurrent users)var(--accent-cyan), etc.).bak,.old,console.logdebug lines, or test scripts includedScreenshots (if visual change)
(none)