Add protocol-level emergency pause mechanism#400
Open
wheval wants to merge 2 commits into
Open
Conversation
Adds pause() and unpause() admin-only functions that set a persistent paused flag and emit ProtocolPaused/ProtocolUnpaused events. buy_key, sell_key, and register_creator check the flag and revert with ProtocolPaused when active. All read-only view functions are unaffected. Adds Unauthorized error variant for non-admin callers. Closes accesslayerorg#393
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pause()andunpause()admin-only functions gated byset_protocol_adminPausedboolean flag in contract storage (defaultfalse)ProtocolPaused/ProtocolUnpausedevents on each state changebuy_key,sell_key, andregister_creatorcheck the flag and revert withProtocolPaused(error variant 17) when activeget_*/quote_*/is_*read-only view functions are completely unaffectedUnauthorizederror variant (18) for non-admin callers topause/unpauseAcceptance criteria
pause()sets the flag and emitsProtocolPausedeventunpause()clears the flag and emitsProtocolUnpausedeventProtocolPausedwhen pausedProtocolPausedwhen pausedProtocolPausedwhen pausedpauseorunpauseis rejected withUnauthorizedCloses #393