Closed
Conversation
added 4 commits
March 9, 2022 11:47
FJShen
changed the title
…ng a bare pointer. This was one of the causes for memory leak in PTX mode
FJShen
changed the title
FJShen
commented
Mar 21, 2022
| unsigned num_inst = m_instructions.size(); | ||
| m_instr_mem_size = MAX_INST_SIZE * (num_inst + 1); | ||
| m_instr_mem = new ptx_instruction *[m_instr_mem_size]; | ||
| m_instr_mem = std::unique_ptr<ptx_instruction*[]>(new ptx_instruction* [m_instr_mem_size]); |
Author
There was a problem hiding this comment.
The entire array allocated by new[] will be destroyed and deleted once m_instr_mem - the unique_ptr - goes out of scope.
Draft
Author
|
continued at PR #34 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed several memory leaks or incorrect memory allocations . Bugs were identified by running valgrind on AccelSim in PTX mode.