Repository navigation
Writer's indication pass: the disease on each entry (ADR 0053, decision 2) - #128
Merged
Merged
Conversation
…med try (ADR 0053) catalyst.publish.indication, under the writer's lock: for each catalyst with no indication, it takes the latest indication_attempt; only when that try found one, it checks the claim is the catalyst's own, the second reader's pass is stored, and the quote still matches its stored copy (gate.match_quote), then sets indication_id (one indication row per MeSH disease) and writes a change row citing the claim. A later refusal wins over an earlier find; an indication already set is never changed. The read API names the indication in its claim's own words, not the MeSH name. The weekday extract run asks both readers about newly published catalysts right after the writer, then runs the pass; publish-claims runs the pass too. No workflow, role, or cap changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NZBSRQTWBsnjC6tv6a2PDo
…he words Separate Opus review of 954a5a8: a storage, hash, or parse error while reading the MeSH file escaped the extract command and lost every earlier summary. The job now reports such an error as a blocked run, reads the file only when there is a catalyst to ask about, and the extract chain runs the readers and the writer's pass as separate steps, so finds kept by earlier runs are still written when the readers fail; any failure still turns the run red. Also: the writer holds an indication whose words are not in its quote, or whose MeSH values are invalid, on its own instead of failing the pass; the read API falls back to the MeSH name when the words are not in the cited quote; extract-catalysts refuses a --limit below 1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NZBSRQTWBsnjC6tv6a2PDo
acarchidi
marked this pull request as ready for review
November 12, 2026 18:20
Contributor
Overseer: did not finishThe overseer's answer could not be used (the answer is not JSON), so nothing was done. Re-run the check. |
Contributor
Claude review: did not finishThe reviewer returned no usable result. Re-run the check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed (plain English)
This is the last step for indications: the disease now appears on each catalyst.
catalyst publish-claimsruns the writing step too.Roadmap item and checkpoint
Phase 7, "Facts on every entry" → "Indication" → "The writer", step 3 of 3, ticked here. Leads to CP7b. The parent "Indication" item stays open until the first live run shows its coverage.
How it was tested
Risks
Existing tests edited:
tests/test_cli.pygains one automatic stand-in fixture for the two new steps, in the same style as its five other database-job stand-ins. No assertion changed.tests/extract/test_indicate.pyhelpers were renamed from private to public names so the new test file can reuse them. No assertion changed.Needed from the owner
Nothing.
Checklist
🤖 Generated with Claude Code
https://claude.ai/code/session_01NZBSRQTWBsnjC6tv6a2PDo