docs: clarify release steps in CONTRIBUTING.md#585
Conversation
WalkthroughUpdated CONTRIBUTING.md: corrected release step numbering/formatting, removed a stray list marker, reordered and renumbered post-merge release actions, removed Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
bfeb98d to
e2c6920
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
CONTRIBUTING.md (1)
201-205: Clarify that pub.dev publishing is now automated via Release Workflow.The restructured release process (steps 10–14) removes the manual
flutter pub publishstep and introduces automated publishing through the Release Workflow (step 13). While this is a good practice, the documentation should explicitly state that pub.dev publication is now delegated to the CI/CD workflow rather than run manually. This will help maintainers understand the flow and avoid duplicate publication attempts.Consider adding a clarifying note before step 10, such as:
+After the release PR is landed: + 10. Create a tag named like `v1.2.3`, using `git tag v1.2.3`This makes it clear that the next phase shifts from PR approval to automated release tasks.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
CONTRIBUTING.md(2 hunks)
🧰 Additional context used
🪛 LanguageTool
CONTRIBUTING.md
[uncategorized] ~191-~191: The official name of this software platform is spelled with a capital “H”.
Context: ...ntegration/ios - Commit this 4. Run [github_changelog_generator`](https://github.co...
(GITHUB)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: android
- GitHub Check: ios
- GitHub Check: android (24)
- GitHub Check: ios
- GitHub Check: android (29)
🔇 Additional comments (1)
CONTRIBUTING.md (1)
191-195: Approve added guidance for URL replacement.The new instruction at line 195 to replace
HEADin autogenerated URLs with the actual version tag (e.g.,v1.2.3) is helpful and removes ambiguity. This clarification improves the release process documentation.
e2c6920 to
3006413
Compare
3006413 to
2952784
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
CONTRIBUTING.md (1)
203-203:⚠️ Potential issue | 🟡 MinorFix malformed markdown link syntax.
The link contains double opening parentheses
]((https://...))and should be](https://...).🔧 Proposed fix
-12. Create a release on GitHub following the [previous releases]((https://github.com/ably/ably-flutter/releases)) as examples. +12. Create a release on GitHub following the [previous releases](https://github.com/ably/ably-flutter/releases) as examples.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@CONTRIBUTING.md` at line 203, The markdown link in the CONTRIBUTING.md line "Create a release on GitHub following the [previous releases]((https://github.com/ably/ably-flutter/releases)) as examples." is malformed due to double opening parentheses; replace the sequence "]((https://github.com/ably/ably-flutter/releases))" with the correct markdown link form "](https://github.com/ably/ably-flutter/releases)" so the "previous releases" anchor links properly.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@CONTRIBUTING.md`:
- Line 204: Update the sentence in CONTRIBUTING.md that currently reads "ask
[ably/team-sdk](https://github.com/orgs/ably/teams/team-sdk) member to approve"
to include the missing article by changing it to "ask an
[ably/team-sdk](https://github.com/orgs/ably/teams/team-sdk) member to approve",
ensuring the rest of the Release Workflow line remains unchanged.
---
Duplicate comments:
In `@CONTRIBUTING.md`:
- Line 203: The markdown link in the CONTRIBUTING.md line "Create a release on
GitHub following the [previous
releases]((https://github.com/ably/ably-flutter/releases)) as examples." is
malformed due to double opening parentheses; replace the sequence
"]((https://github.com/ably/ably-flutter/releases))" with the correct markdown
link form "](https://github.com/ably/ably-flutter/releases)" so the "previous
releases" anchor links properly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
Clarify release steps in CONTRIBUTING.md
Summary by CodeRabbit