Repository navigation
fix: resolve client IP through trusted proxy chains - #5
Merged
Merged
Conversation
abejarano
force-pushed
the
codex/secure-proxy-client-ip
branch
from
August 9, 2026 12:21
862d071 to
41b75bc
Compare
abejarano
marked this pull request as ready for review
August 9, 2026 12:21
Owner
Author
|
🎉 This PR is included in version 1.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
req.ipby walkingX-Forwarded-Forfrom the closest proxy to the first untrusted address.::ffff:127.0.0.1to IPv4.node:net.Root cause
The Bun adapter trusted only the immediate socket and, once trusted, selected the leftmost forwarded address. Behind managed reverse proxies such as Cloud Run this either exposed the proxy address as
req.ipor allowed a client-supplied prefix to be treated as the origin. IPv4-mapped IPv6 normalization also returned an empty string, and IPv6 CIDRs were compared as exact strings.Impact
Applications can configure the exact number or identity of trusted proxy hops and receive a stable client IP without trusting spoofable forwarded prefixes. IPv4-mapped proxy addresses and IPv6 CIDR allowlists now behave correctly.
Validation
bun run buildbun run typecheckbun run test— 20 passed, 0 failedgit diff --check