Skip to content

Prevent save restores from disabling Background Life NPCs - #682

Closed
RANGROO wants to merge 1 commit into
devfrom
codex/preserve-bgl-enrollment-dev
Closed

Prevent save restores from disabling Background Life NPCs#682
RANGROO wants to merge 1 commit into
devfrom
codex/preserve-bgl-enrollment-dev

Conversation

@RANGROO

@RANGROO RANGROO commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Problem

Loading/restoring a save forcibly set background_life_enabled to false for every enrolled NPC. Their database rows remained, but they disappeared from the active Background Life roster.

Fix

  • stop save restoration from disabling all Background Life NPCs
  • add an idempotent migration that re-enrolls affected NPCs which still have automatic actions, letters, or tracking enabled

Related PR

Validation

  • php -l debug/db_updates.php
  • php -l lib/core/npc_master.class.php
  • git diff --check
  • patch verified identical to the focused unstable hotfix
  • local migration completed successfully in chim.log
  • live Background Life API returned 72 enrolled NPCs after repair

Deployment

  • The exact hotfix is active in the local HerikaServer runtime through the current integrated deployment.

@RANGROO
RANGROO marked this pull request as ready for review August 7, 2026 01:11
@RANGROO RANGROO closed this Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant