Skip to content

[FIX] Current error handling within tools leads to ambiguity in the calling process. #329

Description

@isaakchoi

OVERVIEW

Currently, most errors are handled within tools by returning strings like "ERROR: ...". This is then returned by bitbox.py as the tool result with an exit value of 0, masking a failure as a success.

PROPOSAL

Tools should explicitly raise exceptions on failure. The exception message can be captured and returned in stderr, while a return code of 1 flags an error to the calling process.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions