Skip to content

Add github to allowlist for Spicetify marketplace#119

Open
gnuhead-chieb wants to merge 2 commits into
abba23:mainfrom
gnuhead-chieb:main
Open

Add github to allowlist for Spicetify marketplace#119
gnuhead-chieb wants to merge 2 commits into
abba23:mainfrom
gnuhead-chieb:main

Conversation

@gnuhead-chieb
Copy link
Copy Markdown

No description provided.

@abba23
Copy link
Copy Markdown
Owner

abba23 commented Apr 13, 2023

'.*\.libsyn\.com', # podcasts

Is this really neccessary? Unless there's actually a larger number (maybe 5+) of subdomains, I'd like to avoid wildcards and use the specific subdomains in order to keep the list as strict as possible.

'.*\.github\.com', #Github (Spicetify marketplace)
'.*\.githubusercontent\.com', #Github (Spicetify marketplace)

Same question here. The entries should in any case be moved so the list stays sorted alphabetically by top level domain, then second level domain and so on. So github.com and githubusercontent.com would go after genius.com. Adding a space after the # would also help keep the comment format consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants