Feat security rate enforcement#107
Conversation
dominikletica
left a comment
dominikletica
left a comment
There was a problem hiding this comment.
Rate-limiter implementation
Checks:
- PHPUnit OK, 1435 tests, 9446 assertions
- JSTest OK, 37 tests
- All lint checks passed
Ready for review
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2f91ceeddf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
dominikletica
left a comment
dominikletica
left a comment
There was a problem hiding this comment.
Addressed review findings
Checks:
- PHPUnit OK, 1447 tests, 9544 assertions
- JSTest OK, 37 tests
- All lint checks passed
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 268a6bfc5a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
dominikletica
left a comment
dominikletica
left a comment
There was a problem hiding this comment.
Addressed review findings
Checks:
- PHPUnit OK, 1458 tests, 9679 assertions
- JSTest OK, 37 tests
- All lint checks passed
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 91cca74a96
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 38e8c574f5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 126d19e4bc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6aea1c2316
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d5f4261924
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 15aa164db1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6db53a5238
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4ba4bd638c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
dominikletica
left a comment
dominikletica
left a comment
There was a problem hiding this comment.
Addressed review findings
Checks:
- PHPUnit OK, 1615 tests, 10568 assertions
- JSTest OK, 37 tests
- All lint checks passed
Recap: Codex Cloud Review reported 39 issues: 39 solved/fixed.
1 participant
Summary
Implemented the
feat-security-rate-enforcementslice: descriptor-backed Symfony RateLimiter enforcement with centraloff/standard/strict/panicprofiles, Owner-safe ordinary exemptions, explicit scheduler interval enforcement, authenticated-user multipliers,/api/live/**and prefetch exclusions, redacted HTML/JSON429responses, suspicious-probe400handling, fail-open limiter storage diagnostics through the Message layer, scoped login reset hooks, dormant verified-captcha reset interfaces, and the Owner-gated Security settings mode.Testing
bin/phpunit: Passed (1435 tests, 9446 assertions)bin/jstest: Passed (37 tests)bin/lint: Passedphp bin/console render:route /admin/settings/security --role=owner --env=test --no-debug --include-status: returnedHTTP 200Documentation
README.md) - not needed for this branchdev/draft/*.md)dev/CLASSMAP.md)dev/WORKLOG.md)dev/manual/*.md/docs/*.md)Additional Checks
Linked Issues / Discussions
Part of the
feat-securitybranch tree (#102)Review Notes
standardallows one/cron/runper minute,strictone per 15 minutes, andpanicone per hour. Legitimate scheduler429responses are expected caller feedback, not passive security signals.400responses; repeated probe correlation and real blocking decisions are deferred to the later auto-ban/security-signal slice.