ci: run integration tests in GitHub Actions - #109
Open
aalvaropc wants to merge 3 commits into
Open
Conversation
Pin erlang 27.1.2 and nodejs 22.23.2 in .tool-versions (the previous exact pins 27.1 / 22.20.0 are no longer installable via asdf), and align the Dockerfile builder image and CI OTP_VERSION with the same Erlang patch release so local, CI, and release builds use one toolchain. Add `npm ci` to the assets.setup alias: mix setup only installed the tailwind/esbuild binaries, so a fresh clone failed at assets.build with unresolved CodeMirror imports. Remove assets/tsconfig.json, orphan config with no TypeScript sources.
The four integration modules (pg_introspector, catalog sync worker, connection tester, query executor) are tagged :integration and excluded from the default suite, so the code paths that touch a real PostgreSQL had no CI coverage at all. Add a separate `integration` job that reuses the deps cache and runs `mix test --only integration` against the same postgres:17 service; a separate job keeps the fast suite's feedback independent. No second database container is needed: the integration tests point their data sources at the test database itself.
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 21410584 | Triggered | Generic Password | 40adcf9 | .github/workflows/ci.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Added an
integrationjob to the CI workflow that runsmix test --only integrationagainst apostgres:17service, reusing the same deps/_build cache key as the main test job.Why
The four integration modules (
pg_introspector_test,catalog/sync_worker_test,data_sources/connection_tester_test,querying/executor_test) are tagged:integrationand excluded bytest/test_helper.exs, so everything that touches a real PostgreSQL (introspection, catalog sync, connection testing, the query executor with its timeouts and cancellation) had zero CI coverage — a regression there would only surface when someone remembered to runmake test.integrationlocally.A separate job keeps the fast suite's feedback loop independent: a slow or flaky integration run never delays the unit/credo/format signal.
No second database container is needed: the integration tests build their data sources from the
Onesqlx.Repoconfig, pointing at the test database itself.How to test
Build & TestandIntegration Tests).make test.integration— passes (7 integration tests, 0 failures).