Skip to content

Revert contract workspace operations redesign #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wassimbensalem merged 1 commit into from
Aug 19, 2026
Merged

Revert contract workspace operations redesign #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
92 changes: 43 additions & 49 deletions apps/web/app/(app)/contracts/[id]/page.tsx
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 0 additions & 6 deletions apps/web/messages/ar.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,12 +265,6 @@
"upload": "تحميل",
"uploading": "جارٍ التحميل…",
"documentPreview": "معاينة المستند",
"previewPdfDescription": "معاينة ملف PDF الذي تم تحميله.",
"previewNativeDescription": "يمكن تنزيل هذا الملف وفتحه في التطبيق الأصلي.",
"previewDocumentTitle": "معاينة {filename}",
"previewDocxGuidance": "تتوفر المعاينة في المتصفح لملفات PDF. نزّل ملف DOCX هذا لمراجعته في Word أو LibreOffice.",
"downloadDocument": "تنزيل المستند",
"openInNewTab": "فتح في علامة تبويب جديدة",
"approvalSteps": "خطوات المراجعة",
"noApprovalRequests": "لا توجد طلبات موافقة مفتوحة.",
"actionsEyebrow": "متابعة التنفيذ",
Expand Down
6 changes: 0 additions & 6 deletions apps/web/messages/de.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,12 +265,6 @@
"upload": "Hochladen",
"uploading": "Wird hochgeladen…",
"documentPreview": "Dokumentvorschau",
"previewPdfDescription": "Vorschau des hochgeladenen PDFs.",
"previewNativeDescription": "Diese Datei kann heruntergeladen und in ihrer nativen Anwendung geöffnet werden.",
"previewDocumentTitle": "Vorschau von {filename}",
"previewDocxGuidance": "Eine Browservorschau ist für PDFs verfügbar. Laden Sie diese DOCX-Datei herunter, um sie in Word oder LibreOffice zu prüfen.",
"downloadDocument": "Dokument herunterladen",
"openInNewTab": "In neuem Tab öffnen",
"approvalSteps": "Prüfschritte",
"noApprovalRequests": "Es sind keine Genehmigungsanfragen offen.",
"actionsEyebrow": "Umsetzungsverfolgung",
Expand Down
6 changes: 0 additions & 6 deletions apps/web/messages/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,12 +265,6 @@
"upload": "Upload",
"uploading": "Uploading…",
"documentPreview": "Document preview",
"previewPdfDescription": "Previewing the uploaded PDF.",
"previewNativeDescription": "This file can be downloaded and opened in its native application.",
"previewDocumentTitle": "Preview of {filename}",
"previewDocxGuidance": "Browser preview is available for PDFs. Download this DOCX file to review it in Word or LibreOffice.",
"downloadDocument": "Download document",
"openInNewTab": "Open in new tab",
"approvalSteps": "Review steps",
"noApprovalRequests": "No approval requests are open.",
"actionsEyebrow": "Execution tracking",
Expand Down
6 changes: 0 additions & 6 deletions apps/web/messages/es.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,12 +265,6 @@
"upload": "Subir",
"uploading": "Subiendo…",
"documentPreview": "Vista previa del documento",
"previewPdfDescription": "Vista previa del PDF cargado.",
"previewNativeDescription": "Este archivo se puede descargar y abrir en su aplicación nativa.",
"previewDocumentTitle": "Vista previa de {filename}",
"previewDocxGuidance": "La vista previa en el navegador está disponible para PDF. Descarga este archivo DOCX para revisarlo en Word o LibreOffice.",
"downloadDocument": "Descargar documento",
"openInNewTab": "Abrir en una pestaña nueva",
"approvalSteps": "Pasos de revisión",
"noApprovalRequests": "No hay solicitudes de aprobación abiertas.",
"actionsEyebrow": "Seguimiento de ejecución",
Expand Down
6 changes: 0 additions & 6 deletions apps/web/messages/fr.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,12 +265,6 @@
"upload": "Téléverser",
"uploading": "Téléversement…",
"documentPreview": "Aperçu du document",
"previewPdfDescription": "Aperçu du PDF importé.",
"previewNativeDescription": "Ce fichier peut être téléchargé et ouvert dans son application native.",
"previewDocumentTitle": "Aperçu de {filename}",
"previewDocxGuidance": "L’aperçu dans le navigateur est disponible pour les PDF. Téléchargez ce fichier DOCX pour le consulter dans Word ou LibreOffice.",
"downloadDocument": "Télécharger le document",
"openInNewTab": "Ouvrir dans un nouvel onglet",
"approvalSteps": "Étapes de révision",
"noApprovalRequests": "Aucune demande d’approbation n’est ouverte.",
"actionsEyebrow": "Suivi de l’exécution",
Expand Down
12 changes: 0 additions & 12 deletions apps/web/tests/unit/contract-workspace-responsive.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,18 +291,6 @@ describe("contract workspace responsive hierarchy", () => {
expect(screen.getByTestId("contract-detail-grid")).toHaveClass("grid-cols-1", "sm:grid-cols-2")
})

it("uses an agreement-operations control surface rather than a generic card dashboard", async () => {
render(<ContractDetailPage />)

await screen.findByRole("heading", { name: "Master Services Agreement" })
expect(screen.getByTestId("agreement-command-surface")).toHaveAttribute(
"data-surface",
"agreement-operations",
)
expect(screen.getByTestId("agreement-workstreams")).toHaveClass("divide-x")
expect(screen.getByTestId("agreement-workspace-tabs")).toHaveClass("border-b-2")
})

it("keeps CRM out of the contract workspace and presents editing as a structured record", async () => {
render(<ContractDetailPage />)
await screen.findByRole("heading", { name: "Master Services Agreement" })
Expand Down
Loading