updates node to 26, electron to 44 and allows script execution for ce… - #74
Open
Inveracity wants to merge 1 commit into
Open
updates node to 26, electron to 44 and allows script execution for ce…#74Inveracity wants to merge 1 commit into
Inveracity wants to merge 1 commit into
Conversation
…rtain installers when using npm 12
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm run startfails with Node 26.This PR ensures Electron can be installed when using Node 26.
Additionally npm 12 now requires scripts to be explicitly allowed, when installing packages.
Target branch
develop(required)Type of change
How to test
Install Node 26, clone the repo, run
npm installfollowed bynpm run start.Checklist
npm run typecheck:allnpm run test:unitOne failing test on Windows, does not seem like it's related to my changes.
I have opened a separate PR to fix this 🙂
npm run build:renderer(or explain why not)Notes for reviewers
Anything risky, or areas to pay attention to:
I did not test this on Linux, WSL or macos. Nor did I test this with Node 20, 22 or 24.
Review context (please read / use as ground truth)
README.mdGETTING_STARTED.mdMODULE_DEVELOPMENT.mdCONTRIBUTING.mdRUNTIME_TS_TESTING_GUIDELINES.mdE2E_TESTING_GUIDELINES.md