Skip to content

Added onFinished callback to TextLiquidFill - #262

Open
ertgrulll wants to merge 2 commits into
aagarwal1012:masterfrom
ertgrulll:master
Open

Added onFinished callback to TextLiquidFill#262
ertgrulll wants to merge 2 commits into
aagarwal1012:masterfrom
ertgrulll:master

Conversation

@ertgrulll

Copy link
Copy Markdown

Added onFinished callback to TextLiquidFill, readme and example updated according to change.

@SirusCodes

Copy link
Copy Markdown
Collaborator

@aagarwal1012 I guess it will be a great addition to all the animation not only TextLiquidFill, so it would be great if it would be included in AnimatedTextKit class so every animation will get this.
I just wanted to know that if there is any way we already support this?

@ertgrulll

ertgrulll commented Jul 4, 2021

Copy link
Copy Markdown
Author

AnimatedTextKit already has onFinished that triggering on children animations end. But TextLiquidFill is not using as AnimatedTextKit child. I am routing user to another screen on this animation end, so I was need to listen that. I think just TextLiquidFill need this property 🙄

@codecov

codecov Bot commented Jul 4, 2021

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.44%. Comparing base (24c2592) to head (f64bfb8).
⚠️ Report is 44 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #262      +/-   ##
==========================================
+ Coverage   95.38%   95.44%   +0.06%     
==========================================
  Files          10       10              
  Lines         455      461       +6     
==========================================
+ Hits          434      440       +6     
  Misses         21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aagarwal1012
aagarwal1012 requested a review from awhitford July 5, 2021 19:10

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make class TextLiquidFill extends AnimatedText,
so that we use this animation just like all other as a part of AnimatedTextKit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants