Skip to content

fix(blog): copy buttons on prompts hub + numbering fix #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aafre wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(blog): copy buttons on prompts hub + numbering fix #552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2c8fa09
fix(blog): add copy buttons to prompts hub + fix recommendation numbe…
aafre May 26, 2026
86b87da
refactor(blog): use shared CopyablePrompt for hub workflow prompts
aafre May 26, 2026
991b6c5
fix(blog): use <code> instead of <span> for prompt content
aafre May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion resume-builder-ui/src/__tests__/AIResumePromptsHub.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ describe("AIResumePromptsHub", () => {
).toBeInTheDocument();
});

expect(container.querySelectorAll("pre code")).toHaveLength(5);
expect(screen.getAllByRole("heading", { level: 4, name: "Prompt" })).toHaveLength(5);
expect(
screen.getByRole("table", {
name: /AI resume privacy controls by provider/i,
Expand Down
9 changes: 6 additions & 3 deletions resume-builder-ui/src/components/blog/AIResumePromptsHub.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { Link } from "react-router-dom";
import BlogLayout from "../BlogLayout";
import CopyablePrompt from "../shared/CopyablePrompt";
import RevealSection from "../shared/RevealSection";

const REVIEW_DATE = "2026-05-25";
Expand Down Expand Up @@ -569,9 +570,11 @@ export default function AIResumePromptsHub() {
<article key={step.title} className="bg-white rounded-2xl p-6 md:p-8 shadow-premium card-gradient-border">
<h3 className="font-display text-xl font-bold text-ink">{step.title}</h3>
<p className="mt-3 text-stone-warm leading-relaxed">{step.description}</p>
<pre className="mt-4 bg-ink text-white/90 rounded-xl p-4 md:p-6 text-sm leading-relaxed overflow-x-auto">
<code>{step.code}</code>
</pre>
<div className="mt-4 not-prose">
<CopyablePrompt title="Prompt" copyText={step.code}>
<code className="whitespace-pre-wrap">{step.code}</code>
</CopyablePrompt>
Comment on lines +574 to +576
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using a tag instead of a is more semantically correct for representing code snippets or prompts, which improves accessibility for screen readers and SEO.

Suggested change
<CopyablePrompt title="Prompt" copyText={step.code}>
<span className="whitespace-pre-wrap">{step.code}</span>
</CopyablePrompt>
<CopyablePrompt title="Prompt" copyText={step.code}>
<code className="whitespace-pre-wrap">{step.code}</code>
</CopyablePrompt>

Copy link
Copy Markdown
Owner Author

@aafre aafre May 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gemini-code-assist Good catch — applied in 991b6c5. <code> is more semantic for copy-paste prompt snippets.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood. Since the change has already been applied and verified, no further action is required on this thread.

</div>
</article>
))}
</div>
Expand Down
2 changes: 1 addition & 1 deletion resume-builder-ui/src/components/blog/BestFreeResumeBuilders2026.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -603,7 +603,7 @@ export default function BestFreeResumeBuilders2026() {
{i + 1}
</div>
<div>
<h3 className="font-bold text-ink mb-1">{rec.scenario}</h3>
<p className="font-bold text-ink mb-1">{rec.scenario}</p>
<p className="text-stone-warm">
<strong>Pick: </strong>
{rec.link ? (
Expand Down
Loading