Skip to content

fix(ios): clarify lyric browsing time and settings title - #17

Merged
a3384379 merged 1 commit into
masterfrom
codex/full-lyrics-clean-layout
Oct 10, 2026
Merged

a3384379 merged 1 commit into
masterfrom
codex/full-lyrics-clean-layout

Conversation

@a3384379

Copy link
Copy Markdown
Owner

滚动全屏歌词时,原来的每行播放图标重复占位,“回到当前歌词”会遮住歌词。现在移除行内播放图标,将返回按钮放在独立区域;浏览时在定位歌词右侧显示该句的起始时间,并用浅色文字和左侧细线标明归属。时间栏宽度保持固定,长句、翻译和罗马音不会因时间出现而重新排版。

拖动、惯性滚动和停止惯性的触摸只用于浏览,点击歌词仍通过既有路径跳转。恢复跟随、点击歌词和切歌会清理定位状态。歌词设置页改用居中的完整导航标题,解决左上角标题被截为“歌…”的问题。

验证:

  • iOS 18.3 模拟器:146 项 XCTest 全部通过,覆盖定位几何、长句/翻译、歌词身份切换、时间格式和滚动误触保护;已检查原生组件渲染。
  • iPhone:最终版已重新构建、安装并启动;full 和 quick smoke 均为 PASS,Required 6/6。三个可选 BLE 检查跳过,实际拖动/点击及 Sony 联动效果仍需人工验收。
  • git diff --check 和字符串目录 JSON/重复键检查通过。

BLE 协议、Sony/Android 代码、歌词解析和播放时钟没有改变。

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-10T18:12:40.830137Z f50c73b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@a3384379
a3384379 merged commit 85cee48 into master Oct 10, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant