Skip to content

Improve iOS lyric settings and floating display - #15

Merged
a3384379 merged 1 commit into
masterfrom
codex/lyrics-display-ux-fixes
Oct 7, 2026
Merged

a3384379 merged 1 commit into
masterfrom
codex/lyrics-display-ux-fixes

Conversation

@a3384379

@a3384379 a3384379 commented Oct 7, 2026

Copy link
Copy Markdown
Owner

Summary

  • Add a “词” shortcut on the player and a dedicated Lyric Settings page for Dynamic Island lyrics, floating lyrics, line count, title visibility, and six background palettes. Both display switches start off on every cold launch; appearance persists, and the floating switch follows window completion/failure.
  • Remove the floating preview/footer from the player. Use a compact single/double lyric strip with title and control feedback rows only when needed. Dynamic Island keeps artwork and uses a fixed 120×26pt lyric area with two reserved lines when expanded.
  • Prepare the real visible PiP source inside settings, return after a successful system callback, and retain rendering when the page disappears. Queue an explicit reopen while the previous window is stopping; cancellation clears that intent. Preserve the existing publication, playback-authority, command-outcome, and renderer recovery fixes.

Compatibility

  • No BLE protocol or UUID changes
  • Old iOS/Sony build compatibility considered; no Sony/Android changes
  • QQ Music-only scope preserved

Validation

  • Relevant unit tests passed: 135/135 on iPhone 16 Pro Max / iOS 18.3 simulator (68 lyrics, 67 stability). Final source hashes match the tested and installed version.
  • iOS full smoke PASS, Required 6/6: signed App/Widget build, iPhone installation, launch, logs, preferences, and container checks actually executed. Optional BLE/artwork/CurrentWord checks skipped explicitly.
  • Android smoke applicability checked: no Android/Sony changes, so no local Android smoke required; cross-platform CI still runs.
  • Full real-device acceptance: iPhone 16 Pro Max / iOS 26.4 cold-start logs confirm both switches off and preserve single-line/warm appearance. Normal activation received didStart/active with a 320×30 source and approximately 418×39 system render callback. Repeated close/reopen, visual quality across apps, lock screen, interruptions, multiple activities, and prolonged background operation remain pending.

Validation records: docs/LYRICS_DISPLAY_IMPLEMENTATION.md. Local artifacts: tests-settings-reviewed.xcresult, ios-settings-reviewed-full/report.json, and the corresponding source manifest in /private/tmp/musicble-lyrics-ui-cleanup/.

Diagnostics and privacy

  • Logs and screenshots are not included in the commit; only verification summaries are recorded
  • No signing keys, provisioning profiles, deployment state, or user caches are included

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-07T23:39:19.191310Z 722a942 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@a3384379
a3384379 merged commit c02ba96 into master Oct 7, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant