Skip to content

chore(ios): submit localization and deployment updates - #12

Merged
a3384379 merged 2 commits into
masterfrom
codex/localization-deploy-followup
Oct 5, 2026
Merged

a3384379 merged 2 commits into
masterfrom
codex/localization-deploy-followup

Conversation

@a3384379

@a3384379 a3384379 commented Oct 5, 2026 •

Copy link
Copy Markdown
Owner

提交此前保留在本地的六项 iOS 本地化和部署修改。固定设备 ID 失效时,部署入口会回退到唯一可用的 iPhone,并允许设备列表查询短暂失败后重试;续签流程也会等待 Xcode 生成 profile,即使没有旧 profile 可备份,已检测到的新 profile 会在构建失败时保留。

本次复核同时修复了选机缺口:只接受完整的 connected / available 状态,避免把 disconnected / unavailable 误选为可用设备;设备列表查询最终失败时,不使用失败命令留下的部分输出。两个部署入口都按列读取 Identifier,兼容 UDID、ECID 和 CoreDevice UUID,补齐 Xcode 27 设备标识变化后的回退。新增部署 CLI 回归测试并接入 iOS CI。

本地化采用与最新 master 的语义合并,保留主干新增的 26 个歌词文案。Localizable.xcstrings 共 233 项;本地新增的 16 项为 Xcode 提取条目,既有翻译值未修改。未改动 BLE 协议或 Android 业务代码。

验证:

  • 部署入口自动化测试 9/9 通过,外部命令在测试子进程中替换,不连接真机或改动真实签名文件。UDID 和两种 ECID 表达的新增测试在修复前复现失败,修复后全部通过。
  • 三个部署脚本及生成的桌面入口通过 bash -n;git diff --check 通过。
  • 两个 xcstrings 文件 JSON 和语义合并核对通过。
  • 已在 201c30e 的干净工作区运行完整 iOS smoke。原始 Xcode 日志为 BUILD SUCCEEDED,但 Tm iPhone 状态为 unavailable,CoreDevice 无法定位设备,安装、启动及后续检查失败。报告整体仍为 FAIL(required 0/6);报告将 build/install 组合步骤失败同时记为 build 失败,不能以此替代原始构建日志。
  • 真机签名续期、覆盖安装、iPhone/Sony BLE 和歌词展示验收仍未完成。

隔离工作区的代码索引刷新因索引工作进程崩溃失败;合入主工作区后已对 b57ba7f 完成 full 索引,未生成仓库内持久化图谱文件。部署目录不在索引范围内,本轮部署结论仍使用真实文件核对和脚本测试验证。

GitHub CI 已验证当前 head 201c30e461e84b919d9e2b7495c60035d41ea4ed:

  • 分支 CI:部署测试 9/9、iOS XCTest 104/104 首次运行通过,Android 单测及 APK 构建成功。
  • PR CI:所有 job 最终成功。iOS 首次运行在既有 testLastNowPlayingSnapshotStoreSaveLoadAndClear 中出现 load == nil 断言失败;工作流重启模拟器并按既有策略重试后,104/104 通过。部署测试 9/9 首次运行通过。

已合并到 master:b57ba7f0893a8fa0cc7353f1ab639b4e39726745。

合并提交的主干 CI 最终成功:部署测试 9/9 首次运行通过,Android 单测及 APK 构建成功;iOS 同样在上述既有快照存储测试首次失败,按既有策略重试后 104/104 通过。这项间歇失败未在本 PR 修改,不能将重试成功记为首次运行全通过。

原工作区已快进到该 master 提交,无未提交改动、无 ahead/behind 差异。六项原始本地差异已核对与先前快照完全一致,并保留在可恢复的 Git stash 备份中;备份不代表仍有未交付修改。

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 160464c303

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tools/deploy/ios_deploy.sh
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-05T15:17:29.727039Z 160464c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@a3384379
a3384379 merged commit b57ba7f into master Oct 5, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant