Repository navigation
fix(ios): reconcile final lyrics state and playback intent - #11
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
快速回切歌词开关时,Live Activity 可能停在中间状态;PiP 的播放目标也可能在旧回报尚未确认时丢失。此改动落实本轮 R1–R4 审计,让最后展示选择在在途提交完成后生效,并由新的已接受播放回报自动兑现最后播放目标。
R5 的显示 readiness、帧重试、缓冲恢复和系统停止清理保持,PiP 停止不发送 Sony 暂停。协议、Android、偏好格式、Widget 布局和工程配置未修改;原工作目录六项本地修改未纳入。
验证:最终模拟器 XCTest 104/104 通过(新增 13 项,原播放目标测试改为确认回报自动协调),generic iOS App/Widget BUILD SUCCEEDED,无 Swift 编译警告,
git diff --check通过。测试观测真实管理器的发布和命令接口,不代替系统 ActivityKit 或 Sony 设备验收。边界:quick smoke overall FAIL、Required 2/6,其中两项为跳过 build/install;iPhone unavailable,启动、日志、偏好与容器未完成。代码图谱工作树重建再次 worker crash,影响范围由源码、差异、构建与测试复核。跨应用 PiP、灵动岛、BLE/后台及音频真机验收仍待完成。用户已明确要求在这些边界下修改、提交并合并。
详见
docs/LYRICS_DISPLAY_IMPLEMENTATION.md的 R1–R4 整改与验证记录。GitHub 对当前提交
77905901bf42936de1110d8847d1d973b03083d4的验证:PR 与 push 的 iOS XCTest、Android 单测/APK 四项检查最终均为成功。PR 的 iOS 首轮 104/104 通过;push 的 iOS 首轮新增歌词测试 37/37 通过,但原有PerformanceStabilityTests.testLastNowPlayingSnapshotStoreSaveLoadAndClear出现既有的 load=nil 偶发失败,工作流自动重启模拟器后 104/104 通过。该存储测试文件本轮未修改,不能把重试成功表述为已修复该偶发问题。