-
Notifications
You must be signed in to change notification settings - Fork 1.2k
refactor: remove minimal catalog from renderers, keep in spec, and add simple basic samples #1497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
josemontespg
wants to merge
10
commits into
a2ui-project:main
Choose a base branch
from
josemontespg:delete-minimal-catalog
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
d9fdb28
refactor: remove minimal catalog from renderers, keep in spec, and ad…
josemontespg f7e75e9
Merge remote-tracking branch 'upstream/main' into delete-minimal-catalog
josemontespg 9e8ecbc
Merge remote-tracking branch 'upstream/main' into delete-minimal-catalog
josemontespg 69feee4
Merge branch 'upstream/main' into delete-minimal-catalog
josemontespg b859e57
build: update web_core to use v1_0 spec instead of v0_10
josemontespg ad7e0c1
fix(spec): update outdated v0_10 references to v1_0 in v1_0 basic cat…
josemontespg 20ac27e
Merge remote-tracking branch 'upstream/main' into delete-minimal-catalog
josemontespg a2402ec
Merge remote-tracking branch 'upstream/main' into delete-minimal-catalog
josemontespg 4e87f03
fix(spec): fix capitalize function definition in v1_0 basic catalog
josemontespg 1e56cf5
fix(spec): remove returnType from capitalize function call in v1_0 ex…
josemontespg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
89 changes: 89 additions & 0 deletions
89
specification/v0_8/json/catalogs/basic/examples/00_complex-layout.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| [ | ||
| { | ||
| "surfaceUpdate": { | ||
| "surfaceId": "gallery-complex-layout", | ||
| "components": [ | ||
| { | ||
| "id": "root", | ||
| "component": { | ||
| "Column": { | ||
| "children": { | ||
| "explicitList": ["header", "form_row", "footer"] | ||
| }, | ||
| "distribution": "spaceBetween", | ||
| "alignment": "stretch" | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "id": "header", | ||
| "component": { | ||
| "Text": { | ||
| "text": { | ||
| "literalString": "User Profile Form" | ||
| }, | ||
| "usageHint": "h1" | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "id": "form_row", | ||
| "component": { | ||
| "Row": { | ||
| "children": { | ||
| "explicitList": ["first_name", "last_name"] | ||
| }, | ||
| "distribution": "start", | ||
| "alignment": "start" | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "id": "first_name", | ||
| "weight": 1, | ||
| "component": { | ||
| "TextField": { | ||
| "label": { | ||
| "literalString": "First Name" | ||
| }, | ||
| "text": { | ||
| "path": "/firstName" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "id": "last_name", | ||
| "weight": 1, | ||
| "component": { | ||
| "TextField": { | ||
| "label": { | ||
| "literalString": "Last Name" | ||
| }, | ||
| "text": { | ||
| "path": "/lastName" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "id": "footer", | ||
| "component": { | ||
| "Text": { | ||
| "text": { | ||
| "literalString": "Please fill out all fields." | ||
| }, | ||
| "usageHint": "caption" | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| { | ||
| "beginRendering": { | ||
| "surfaceId": "gallery-complex-layout", | ||
| "root": "root" | ||
| } | ||
| } | ||
| ] |
60 changes: 60 additions & 0 deletions
60
specification/v0_8/json/catalogs/basic/examples/00_interactive-button.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| [ | ||
| { | ||
| "surfaceUpdate": { | ||
| "surfaceId": "gallery-interactive-button", | ||
| "components": [ | ||
| { | ||
| "id": "root", | ||
| "component": { | ||
| "Column": { | ||
| "children": { | ||
| "explicitList": ["title", "action_button"] | ||
| }, | ||
| "distribution": "center", | ||
| "alignment": "center" | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "id": "title", | ||
| "component": { | ||
| "Text": { | ||
| "text": { | ||
| "literalString": "Click the button below" | ||
| }, | ||
| "usageHint": "body" | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "id": "action_button", | ||
| "component": { | ||
| "Button": { | ||
| "child": "button_label", | ||
| "primary": true, | ||
| "action": { | ||
| "name": "button_clicked" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "id": "button_label", | ||
| "component": { | ||
| "Text": { | ||
| "text": { | ||
| "literalString": "Click Me" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| { | ||
| "beginRendering": { | ||
| "surfaceId": "gallery-interactive-button", | ||
| "root": "root" | ||
| } | ||
| } | ||
| ] |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.