Skip to content

Build AnyCPU instead of x86 so the plugin loads in 64-bit HDT #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dtroest wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Build AnyCPU instead of x86 so the plugin loads in 64-bit HDT #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions HdtCollectionExporter.sln
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,14 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "HdtCollectionExporter", "sr
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Debug|x86 = Debug|x86
Release|x86 = Release|x86
Debug|Any CPU = Debug|Any CPU
Release|Any CPU = Release|Any CPU
EndGlobalSection
GlobalSection(ProjectConfigurationPlatforms) = postSolution
{8B0A46F7-154C-46B2-93CE-280C83C10A75}.Debug|x86.ActiveCfg = Debug|x86
{8B0A46F7-154C-46B2-93CE-280C83C10A75}.Debug|x86.Build.0 = Debug|x86
{8B0A46F7-154C-46B2-93CE-280C83C10A75}.Release|x86.ActiveCfg = Release|x86
{8B0A46F7-154C-46B2-93CE-280C83C10A75}.Release|x86.Build.0 = Release|x86
{8B0A46F7-154C-46B2-93CE-280C83C10A75}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{8B0A46F7-154C-46B2-93CE-280C83C10A75}.Debug|Any CPU.Build.0 = Debug|Any CPU
{8B0A46F7-154C-46B2-93CE-280C83C10A75}.Release|Any CPU.ActiveCfg = Release|Any CPU
{8B0A46F7-154C-46B2-93CE-280C83C10A75}.Release|Any CPU.Build.0 = Release|Any CPU
EndGlobalSection
GlobalSection(SolutionProperties) = preSolution
HideSolutionNode = FALSE
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ Build from the repository root:
Build output:

```text
src\HdtCollectionExporter\bin\x86\Release\HdtCollectionExporter.dll
src\HdtCollectionExporter\bin\Release\HdtCollectionExporter.dll
```

## Project Structure
Expand Down
12 changes: 6 additions & 6 deletions build.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ if (Test-Path $targetingPack) {
& $msbuild ".\HdtCollectionExporter.sln" `
/m `
/p:Configuration=$Configuration `
/p:Platform=x86 `
/p:Platform="Any CPU" `
/p:HDTInstallDir="$HDTInstallDir"

if ($LASTEXITCODE -ne 0) {
Expand All @@ -41,14 +41,14 @@ if (Test-Path $targetingPack) {
Write-Host ".NET Framework 4.7.2 targeting pack was not found. Using local fallback compiler path."

$projectDir = Join-Path $PSScriptRoot "src\HdtCollectionExporter"
$objDir = Join-Path $projectDir "obj\x86\$Configuration"
$outDir = Join-Path $projectDir "bin\x86\$Configuration"
$objDir = Join-Path $projectDir "obj\$Configuration"
$outDir = Join-Path $projectDir "bin\$Configuration"
New-Item -ItemType Directory -Force -Path $objDir, $outDir | Out-Null

$legacyMsbuild = Join-Path $env:WINDIR "Microsoft.NET\Framework\v4.0.30319\MSBuild.exe"
& $legacyMsbuild (Join-Path $projectDir "HdtCollectionExporter.csproj") `
/p:Configuration=$Configuration `
/p:Platform=x86 `
/p:Platform="Any CPU" `
/p:TargetFrameworkVersion=v4.0 `
/p:HDTInstallDir="$HDTInstallDir" *> $null

Expand Down Expand Up @@ -109,15 +109,15 @@ $sources = @(
"Settings\PluginSettings.cs",
"UI\ExportWindowText.cs",
"UI\ExportWindow.xaml.cs",
"obj\x86\$Configuration\UI\ExportWindow.g.cs"
"obj\$Configuration\UI\ExportWindow.g.cs"
)

Push-Location $projectDir
try {
& $csc `
/noconfig `
/target:library `
/platform:x86 `
/platform:anycpu `
/langversion:latest `
/optimize+ `
"/out:$outDir\HdtCollectionExporter.dll" `
Expand Down
2 changes: 1 addition & 1 deletion docs/INSTALL.en.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ If the script cannot find HDT automatically, pass the HDT app folder:
The build output is:

```text
src\HdtCollectionExporter\bin\x86\Release\HdtCollectionExporter.dll
src\HdtCollectionExporter\bin\Release\HdtCollectionExporter.dll
```

## 4. Open The HDT Plugins Folder
Expand Down
2 changes: 1 addition & 1 deletion docs/INSTALL.ru.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ HdtCollectionExporter.dll
Готовый файл будет здесь:

```text
src\HdtCollectionExporter\bin\x86\Release\HdtCollectionExporter.dll
src\HdtCollectionExporter\bin\Release\HdtCollectionExporter.dll
```

## 4. Открыть папку расширений HDT
Expand Down
18 changes: 9 additions & 9 deletions src/HdtCollectionExporter/HdtCollectionExporter.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

<PropertyGroup>
<Configuration Condition="'$(Configuration)' == ''">Debug</Configuration>
<Platform Condition="'$(Platform)' == ''">x86</Platform>
<Platform Condition="'$(Platform)' == ''">AnyCPU</Platform>
<ProjectGuid>{8B0A46F7-154C-46B2-93CE-280C83C10A75}</ProjectGuid>
<OutputType>Library</OutputType>
<RootNamespace>HdtCollectionExporter</RootNamespace>
Expand All @@ -17,23 +17,23 @@
<HDTInstallDir Condition="'$(HDTInstallDir)' == ''">$(LocalAppData)\HearthstoneDeckTracker\app-1.52.7</HDTInstallDir>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Debug|x86'">
<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Debug|AnyCPU'">
<DebugSymbols>true</DebugSymbols>
<DebugType>full</DebugType>
<Optimize>false</Optimize>
<OutputPath>bin\x86\Debug\</OutputPath>
<OutputPath>bin\Debug\</OutputPath>
<DefineConstants>DEBUG;TRACE</DefineConstants>
<PlatformTarget>x86</PlatformTarget>
<Prefer32Bit>true</Prefer32Bit>
<PlatformTarget>AnyCPU</PlatformTarget>
<Prefer32Bit>false</Prefer32Bit>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Release|x86'">
<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Release|AnyCPU'">
<DebugType>pdbonly</DebugType>
<Optimize>true</Optimize>
<OutputPath>bin\x86\Release\</OutputPath>
<OutputPath>bin\Release\</OutputPath>
<DefineConstants>TRACE</DefineConstants>
<PlatformTarget>x86</PlatformTarget>
<Prefer32Bit>true</Prefer32Bit>
<PlatformTarget>AnyCPU</PlatformTarget>
<Prefer32Bit>false</Prefer32Bit>
</PropertyGroup>

<ItemGroup>
Expand Down