Repository navigation
Conversation
Keep terminal execution independent from output visibility. Preserve existing behavior until users enable the setting. Refs Zoo-Code-Org#605
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📜 Recent review details
📝 Summary
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Description check |  |
The description covers the implementation, behavior, tests, visual snapshots, documentation impact, and pending review status. However, the required approved issue link is incomplete: it uses “Related… | Link the pull request to an approved GitHub issue using the required format, such as “Closes: #605”, and update the Issue Linked checklist item after approval and assignment are complete. |
-
Check name Status Explanation Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Regression Evidence Focused coverage is present for the changed behavior. Schema tests cover true, false, undefined, and non-boolean input. ClineProvider and updateSettings tests cover state defaults, persistence, and te… Security Boundaries No changed path meets the security failure conditions. The new setting is an optional boolean in globalSettingsSchema(packages/types/src/global-settings.ts:242) and is projected through state. `C…Persistence Integrity No changed persistence defect found. The settings save path sends collapseCommandOutputByDefaultthrough the existingupdateSettingsloop, which awaitscontextProxy.setValuebefore posting updat…Lifecycle Resource Cleanup The changed paths add only setting state propagation and collapse-state logic. CommandExecutionstill registers its existingmessagelistener throughuseEvent; the PR only adds the preference to…Title check The title clearly identifies the main change: adding a terminal setting that collapses command output by default. Full details: Regression Evidence
-
Explanation
Focused coverage is present for the changed behavior. Schema tests cover true, false, undefined, and non-boolean input. ClineProvider and updateSettings tests cover state defaults, persistence, and terminal-mode isolation. CommandExecution tests cover both terminal modes, all preference values, fallback, streaming, completed output, and manual expand/collapse. SettingsView tests cover buffered edits, Save, and live refresh behavior. The visible TerminalSettings change has a Playwright component snapshot for all four themes.
Full details: Security Boundaries
-
Explanation
No changed path meets the security failure conditions. The new setting is an optional boolean in
globalSettingsSchema(packages/types/src/global-settings.ts:242) and is projected through state.CommandExecutiononly changes output visibility (webview-ui/src/components/chat/CommandExecution.tsx:61,163-169); command pattern allow/deny controls and terminal operations remain unchanged (:238-264). The settings handler persists the value but does not execute it or alter approval and allowlist enforcement (src/core/webview/webviewMessageHandler.ts:760-873). No changed code exposes secrets or PII.
Full details: Persistence Integrity
-
Explanation
No changed persistence defect found. The settings save path sends
collapseCommandOutputByDefaultthrough the existingupdateSettingsloop, which awaitscontextProxy.setValuebefore posting updated state (src/core/webview/webviewMessageHandler.ts:760-873).ContextProxy.setValueawaits the existing global-state update path (src/core/config/ContextProxy.ts:538-542), and this PR does not change the existing bulksetValuesimplementation. The new optional schema key is included in global settings, and both ClineProvider webview-state projections applyDEFAULT_COLLAPSE_COMMAND_OUTPUT_BY_DEFAULT;CommandExecutionconsumes that propagated value.
Full details: Lifecycle Resource Cleanup
-
Explanation
The changed paths add only setting state propagation and collapse-state logic.
CommandExecutionstill registers its existingmessagelistener throughuseEvent; the PR only adds the preference to the callback dependency list, with no new listener, timer, watcher, task, or provider. No changed lifecycle path can leak a resource or duplicate work after disposal or restart.
-
Full details: Description check
-
Explanation
The description covers the implementation, behavior, tests, visual snapshots, documentation impact, and pending review status. However, the required approved issue link is incomplete: it uses “Related to
#605” instead of the required closing link, and the checklist confirms maintainer approval and assignment are still pending.Resolution
Link the pull request to an approved GitHub issue using the required format, such as “Closes:
#605”, and update the Issue Linked checklist item after approval and assignment are complete.
- Fix all pre-merge checks with AI
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Generate and compare all four VS Code theme snapshots in the pinned Playwright container. Refs Zoo-Code-Org#605
Review statusThanks for contributing. This comment tracks the review sequence and the next action. Current step: Awaiting fresh human maintainer or CODEOWNER approval. Automated review is complete for the latest commit but does not replace human approval. Review-state labels are managed by this workflow; do not edit them manually. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
github-actions
Bot
added
the
has-conflicts
github-actions
Bot
removed
the
has-conflicts
github-actions
Bot
added
coderabbit-review-active
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
github-actions
Bot
added
awaiting-maintainer
This branch has not been deployed
1 participant
Related GitHub Issue
Related to #605.
The author has posted
Claimingon the issue. Maintainer assignment is pending.Description
Verbose Inline Terminal output can fill the chat. Add an independent Collapse command output by default setting under Terminal.
This supports Enhanced User Experience. Command execution, output collection, and the selected terminal backend stay unchanged.
This PR implements the independent preference requested in #605. It does not add a last-lines preview or a new exit-code summary.
Test Procedure
Passed locally:
git diff --check.Repeat the focused tests:
Manual review:
Local tools: macOS, Node 24.21.0, pnpm 10.8.1. The repository requests Node 22.23.1.
Pre-Submission Checklist
Visual Snapshots
TerminalSettings.visual.tsxcovers the production settings screen in dark, light, high-contrast, and high-contrast-light themes.The four baselines were generated and compared in the repository-pinned Playwright Docker image.
The temporary container path contains Corepack pnpm shims. Lockfile dependencies include Linux native packages for the container run.
No repository dependency files changed.
Documentation Updates
The setting contains translated help text. No separate documentation change is required for this PR.
Additional Notes
Codex helped implement and test this change. Human review and maintainer assignment are required before marking this draft ready.
The PR keeps existing users on the current display behavior until they enable the preference.